Skip to content

feat: Add Sort by in default view of Shared Drive (WPB-26232) - #5132

Open
ohassine wants to merge 2 commits into
developfrom
Add-Sort-by-in-default-view-of-Shared-Drive
Open

feat: Add Sort by in default view of Shared Drive (WPB-26232)#5132
ohassine wants to merge 2 commits into
developfrom
Add-Sort-by-in-default-view-of-Shared-Drive

Conversation

@ohassine

@ohassine ohassine commented Aug 4, 2026

Copy link
Copy Markdown
Member

https://wearezeta.atlassian.net/browse/WPB-26232


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Description

Add Sorting to main screen of Shared Drive and Drive

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@codecov

codecov Bot commented Aug 4, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 90.90909% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 50.20%. Comparing base (de54546) to head (bfae6e0).
⚠️ Report is 3 commits behind head on develop.

Files with missing lines Patch % Lines
...com/wire/android/feature/cells/ui/CellViewModel.kt 88.88% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #5132      +/-   ##
===========================================
+ Coverage    50.15%   50.20%   +0.04%     
===========================================
  Files          666      666              
  Lines        24397    24398       +1     
  Branches      3780     3778       -2     
===========================================
+ Hits         12237    12249      +12     
+ Misses       11039    11032       -7     
+ Partials      1121     1117       -4     
Files with missing lines Coverage Δ
...id/feature/cells/ui/model/NodeBottomSheetAction.kt 100.00% <100.00%> (ø)
...com/wire/android/feature/cells/ui/CellViewModel.kt 48.80% <88.88%> (+0.28%) ⬆️

... and 7 files with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de54546...bfae6e0. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions

github-actions Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Test Results

2 177 tests  +4   2 177 ✅ +4   1m 57s ⏱️ +24s
  237 suites ±0       0 💤 ±0 
  237 files   ±0       0 ❌ ±0 

Results for commit bfae6e0. ± Comparison against base commit de54546.

♻️ This comment has been updated with latest results.

@saleniuk saleniuk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment about the inconsistency, would be nice to sort it out soon.

val isOnline = isOnlineState || !viewModel.offlineFilesEnabled
val sortingCriteria by viewModel.sortingCriteria.collectAsState()

val lazyListState = rememberLazyListState()

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On "Drive" screen, the search top bar doesn't disappear when user scrolls, like on conversation list or archive. To fix that inconsistency, we need to use the search bar from HomeScreen instead of creating yet another one in the content of cells screen, and use LazyListState from homeStateHolder.lazyListStateFor(HomeDestination.Cells) instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants