feat: Add Sort by in default view of Shared Drive (WPB-26232) - #5132
feat: Add Sort by in default view of Shared Drive (WPB-26232)#5132ohassine wants to merge 2 commits into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #5132 +/- ##
===========================================
+ Coverage 50.15% 50.20% +0.04%
===========================================
Files 666 666
Lines 24397 24398 +1
Branches 3780 3778 -2
===========================================
+ Hits 12237 12249 +12
+ Misses 11039 11032 -7
+ Partials 1121 1117 -4
... and 7 files with indirect coverage changes Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
saleniuk
left a comment
There was a problem hiding this comment.
Just one comment about the inconsistency, would be nice to sort it out soon.
| val isOnline = isOnlineState || !viewModel.offlineFilesEnabled | ||
| val sortingCriteria by viewModel.sortingCriteria.collectAsState() | ||
|
|
||
| val lazyListState = rememberLazyListState() |
There was a problem hiding this comment.
On "Drive" screen, the search top bar doesn't disappear when user scrolls, like on conversation list or archive. To fix that inconsistency, we need to use the search bar from HomeScreen instead of creating yet another one in the content of cells screen, and use LazyListState from homeStateHolder.lazyListStateFor(HomeDestination.Cells) instead.
https://wearezeta.atlassian.net/browse/WPB-26232
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Description
Add Sorting to main screen of Shared Drive and Drive
Needs releases with:
Testing
Test Coverage (Optional)
How to Test
Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.
Notes (Optional)
Specify here any other facts that you think are important for this issue.
Attachments (Optional)
Attachments like images, videos, etc. (drag and drop in the text box)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.