fix: respect SERVICEKIT_HOST env var in service registration#10
Merged
fix: respect SERVICEKIT_HOST env var in service registration#10
Conversation
The host resolution order was parameter -> auto-detect -> env var, meaning socket.gethostname() always succeeded first and the env var was never consulted. Changed to parameter -> env var -> auto-detect, matching how SERVICEKIT_PORT resolution already works.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
parameter -> auto-detect -> env vartoparameter -> env var -> auto-detectsocket.gethostname()almost always succeeds, so the env var was effectively dead codeSERVICEKIT_PORTresolution already worksContext
When chap-core runs in Docker and a servicekit service runs on the host, the auto-detected hostname (e.g.
mlaptop.local) is not resolvable from inside Docker. SettingSERVICEKIT_HOST=host.docker.internalhad no effect.Test plan