Replace Ace Editor with Monaco Editor #801
Merged
+26,692
−4,349
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add most configuration options - Dispose and create editor depending on whether in view - Fix sizing issue
bennothommo
added
enhancement
This comment was marked as outdated.
This comment was marked as outdated.
LukeTowers
previously requested changes
Dec 13, 2022
modules/backend/controllers/preferences/_field_editor_preview.php
Outdated
Show resolved
Hide resolved
…wip/monaco-editor
… events for editor
For anyone else trying to track down self being clobbered, this is very handy:
(function () {
try {
const desc = Object.getOwnPropertyDescriptor(window, 'self');
console.log('window.self descriptor:', desc);
let _selfValue = window;
Object.defineProperty(window, 'self', {
configurable: true,
get() { return _selfValue; },
set(v) {
console.error('window.self set to:', v);
console.trace('stack:'); // <- prints the exact script/line
_selfValue = v;
},
});
} catch (e) {
console.warn('Failed to trap window.self:', e);
}
})();
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Also added build cleanup step to build process to avoid leaving behind artifacts from previous builds.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
# Conflicts: # modules/backend/assets/vendor/ace-codeeditor/build-min.js
Code didn't really do anything even with the aceeditor.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
In theory only used by the Winter.Notify plugin, and even then, only if someone has a custom action defined that makes use of a codeeditor field.
LukeTowers
approved these changes
Jan 21, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #431. Related: wintercms/wn-builder-plugin#73
This PR introduces the Monaco editor in replacement of the Ace Editor. At this stage for the PR, we are aiming for parity with the functionality previously provided by Ace, with the intention of increasing the functionality after this PR is merged.
Still to do:
Changes:
Summary by CodeRabbit
New Features
Improvements
Bug Fixes
Documentation
✏️ Tip: You can customize this high-level summary in your review settings.