[alloc+atomic] Make GhostTreeBStackAllocator Sync under the atomic feature flag#13
Merged
Conversation
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
GhostTreeBStackAllocator Sync under the atomic feature flag
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates GhostTreeBstackAllocator to support safe concurrent &self usage under the atomic feature flag, making the allocator Sync by serializing AVL free-tree mutations with an internal mutex and using BStack’s atomic tail operations (try_extend_zeros, try_discard) where possible.
Changes:
- Add a
Mutex<()>field behindcfg(feature = "atomic")and remove the!Syncmarker in that configuration. - Wrap AVL free-tree remove/insert operations in the mutex and restructure
alloc/alloc_bulkto release the lock before potentially expensiveextend/zerocalls. - Use
try_discard/try_extend_zerosas lock-free fast paths for tail shrink/grow inrealloc,dealloc, anddealloc_bulk, plus update the thread-safety docs and doctest gating accordingly.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: Under the flag
atomic, makingGhostTreeBStackAllocator(Rust) operations atomic and safe across threads with a mutex and bstack atomic methods such astry_extend_zerosandtry_discard, implementing the rust Sync trait.Important Feature: No
Type: Allocator - Optimization; Allocator - Concurrent
Magic Number: ALGT
Bulk: No
Tests: Included
Feature Flags: alloc + set
Breaking change: No
New Types: None
Rust Only: Yes
Fuzz: Yes
Safety Review: Needed: Crash Safety, Invariants, Thread Safety