Skip to content

[WFLY-20952] Added integration tests to the JTS quickstart#1179

Open
jmfinelli wants to merge 1 commit into
wildfly:mainfrom
jmfinelli:WFLY-20952
Open

[WFLY-20952] Added integration tests to the JTS quickstart#1179
jmfinelli wants to merge 1 commit into
wildfly:mainfrom
jmfinelli:WFLY-20952

Conversation

@jmfinelli

Copy link
Copy Markdown
Contributor

Addresses WFLY-20952

@jmfinelli jmfinelli requested a review from emmartins as a code owner June 19, 2026 10:50
@jmfinelli jmfinelli requested a review from kstekovi June 19, 2026 10:51

private long getMessagesAdded() throws IOException {
try (ModelControllerClient client = ModelControllerClient.Factory.create(
InetAddress.getByName("localhost"), SERVER2_MGMT_PORT)) {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should use the host in getServerHost().

Comment thread jts/README-source.adoc

The web page will also change and show you the new list of customers.

NOTE: You can also verify the state of the JMS queue on application server 2 by using the management CLI. Connect to the second server's management interface and run the following command, replacing `__DEPLOYMENT_NAME__` with the actual deployment file name (e.g. `{artifactId}-application-component-2-{version}.jar`):

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

{version} is not defined, so you either pass it from Maven as done at https://github.com/jmfinelli/quickstart-wildfly/blob/WFLY-20952/microprofile-fault-tolerance/pom.xml#L147 , or you set the deployment name's to have no version, as done for application-component-1 at https://github.com/jmfinelli/quickstart-wildfly/blob/WFLY-20952/jts/application-component-1/pom.xml#L109

Comment thread jts/README-source.adoc

This shows the total number of messages added to the queue since the server started. You can find the deployment name by running `ls /deployment` in the CLI.

// Undeploy the Quickstart

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need testing instructions, usually this is done by adding the following include, before the undeploy one:

// Server Distribution Testing
include::../shared-doc/run-integration-tests-with-server-distribution.adoc[leveloffset=+1]

}

private long getMessagesAdded() throws IOException {
try (ModelControllerClient client = ModelControllerClient.Factory.create(

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could use http client for this too, and don't depend on WildFly Core... Honestly I am not sure if the Core's ModelControllerClient should be used by user apps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants