[WFLY-21323] http-custom-mechanism is accepting the req with invalid password#1171
Open
rafaeldarosagit wants to merge 2 commits into
Open
[WFLY-21323] http-custom-mechanism is accepting the req with invalid password#1171rafaeldarosagit wants to merge 2 commits into
rafaeldarosagit wants to merge 2 commits into
Conversation
Contributor
|
thanks @rafaeldarosagit , I will review this week |
emmartins
requested changes
Jun 23, 2026
emmartins
left a comment
emmartins
left a comment
Contributor
There was a problem hiding this comment.
Please also squash the commits into a single one, and which commit message should start with [WFLY-21323]
| final HttpRequest request = HttpRequest.newBuilder() | ||
| .uri(new URI(serverHost+"/http-custom-mechanism-webapp/secured")) | ||
| .header("X-USERNAME", "quickstartUser") | ||
| .header("X-PASSWORD", "quickstartPwd1") |
Contributor
There was a problem hiding this comment.
Password here is wrong too, it should be quickstartPwd1!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: https://redhat.atlassian.net/browse/WFLY-21323
Description: Authentication mechanism was accepting requests with invalid passwords when users had valid authorization groups. Added missing return statement after authentication failed.