Skip to content

Conversation

@ric0de
Copy link
Contributor

@ric0de ric0de commented Dec 1, 2025

ManageMyCandidatesLanding.jsx now only contains routing, navigation, and politician state handling between tabs. All other logic like modals, invites, imports, etc is handled in ManageMyCandidates.jsx (soon-to-be ImportInvitePage.jsx) and the four respective modal files.

…nding.jsx and UI components to other files [TEAM REVIEW]
Copy link

@accesslint accesslint bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are accessibility issues in these changes.

title="Select candidate"
>
<ArrowDownIcon fontSize="small" />
<PickerMenu role="listbox">
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this element is missing an accessible name or label. That makes it hard for people using screen readers or voice control to use the control.

onSelectFile={handleSelectCSV}
allColumnsOK={allColumnsOK}
/>
<input
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this element is missing an accessible name or label. That makes it hard for people using screen readers or voice control to use the control.

Copy link

@accesslint accesslint bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are accessibility issues in these changes.

title="Select candidate"
>
<ArrowDownIcon fontSize="small" />
<PickerMenu role="listbox">
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this element is missing an accessible name or label. That makes it hard for people using screen readers or voice control to use the control.

<SelectButton type="button" onClick={handleSelectCSV}>Select file</SelectButton>
</Footer>

<input
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this element is missing an accessible name or label. That makes it hard for people using screen readers or voice control to use the control.

@ric0de ric0de changed the title [WV-2287] Moved ManageMyCandidates navigation to ManageMyCandidatesLanding.jsx and UI components to other files [TEAM REVIEW] [WV-2287] Moved ManageMyCandidates navigation to ManageMyCandidatesLanding.jsx and UI components to other files [MERGE READY] Dec 9, 2025
@DaleMcGrew
Copy link
Member

Great work @ric0de! 👍

@DaleMcGrew DaleMcGrew merged commit 41c0d5a into wevote:develop Dec 10, 2025
4 checks passed
@ric0de ric0de deleted the WV-2287ManageCandidatesMasterNav branch December 17, 2025 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants