Skip to content

fix: specify vite as peer dep #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

fix: specify vite as peer dep #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4144685
fix: specify vite as peer dep
achou11 Feb 11, 2025
b07ce85
remove vite v5 from peer dep
achou11 Feb 11, 2025
ffeff6e
update vite dev dep
achou11 Feb 11, 2025
3d00651
update @vitejs/plugin-legacy
achou11 Feb 11, 2025
abcadba
use exact vite dev dep version
achou11 Feb 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,16 +33,19 @@
"check": "prettier --check . && tsc --noEmit --allowJs --lib es2017,dom ./src/webxdc.js"
},
"dependencies": {
"@vitejs/plugin-basic-ssl": "^1.1.0",
"@vitejs/plugin-legacy": "^6.0.0",
"@vitejs/plugin-basic-ssl": "^1.2.0",
"@vitejs/plugin-legacy": "^6.0.1",
Copy link
Author

@achou11 achou11 Feb 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

technically out of scope but figured why not 🤷‍♂️

"eruda": "^3.4.1",
"terser": "^5.36.0",
Copy link
Author

@achou11 achou11 Feb 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

curious if terser is needed as an explicit dep?

"vite-plugin-zip-pack": "^1.2.4"
},
"peerDependencies": {
"vite": "^6.0.0"
},
"devDependencies": {
"@webxdc/types": "latest",
"prettier": "latest",
"typescript": "latest",
"vite": "latest"
"vite": "6.1.0"
Copy link
Author

@achou11 achou11 Feb 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

generally better practice to specify a more explicit version range. can revert if not desired though

}
}
Loading