Repository navigation
fix(ios): preserve transparent modal Glass snapshots - #61
Merged
Merged
Conversation
This was referenced Nov 17, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modal rail button snapshots can turn opaque gray even though the live Liquid Glass button looks correct. Restrict the cold-launch in-place filtering workaround to composited window captures; transparent view-root captures now retain their original filtering.
The regression was introduced by #50 (
0a435c0), first included in Engine 1.0.6.CoveredSnapshots.capturerouted both window and explicit-root draws through the same helper, which changed everyglassBackgroundlayer before either kind of draw. That window-specific workaround baked gray pixels into isolated modal PNGs. Restoring the layer flags afterward could not repair the already encoded image. This is present in Engine 1.0.10, used by Capacitor 2.1.10.Both drawing paths still share main-thread enforcement, reentry rejection and the Objective-C exception boundary. Composited window captures keep their existing flag mutation, restoration and failure behavior. Add regression coverage for transparent-root filtering/reentry and window filtering/restoration, and document the scope.
The hosted iOS integration and iOS consumer jobs now allow 20 minutes for their cold builds, simulator setup and validation. Their previous 12-minute total limit interrupted this PR’s integration tests and canceled the Cordova job just after a successful build. Existing simulator/test step limits remain in place; the Swift package job keeps its 12-minute budget.
Validation:
git diff --checkpassed.Captured modal PNG before the fix:
Captured modal PNG with the final fix:
Final demo sheet on the simulator:
This PR changes Engine only. Publishing a new Engine version and updating the Capacitor/Cordova dependency pins are separate release steps.