Repository navigation
refactor: simplify capture docs and test guardrails - #60
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Capture and handoff guidance repeated the same lifecycle across several pages and retained iOS-only wording despite Android contact acquisition. Consolidate that contract, link platform-specific guidance to it, and remove internal planner coefficients and a fixture-specific delay recommendation. Keep configurable defaults, platform limits and teardown requirements explicit.
Consolidate duplicate Controls cases and replace void-return assertions with observable token/ownership checks. Move long-wait and timer-overflow boundaries to the bridge layer, simplify fixtures and SDK diagnostics, and separate Window interception tests from capture-planner tests. Android restoration now checks actual window placement against the DOM within one physical pixel rather than fixing an internal translation value to 0.05px. SDK input, scroll/virtual updates and ownership guards remain covered. Product implementation is unchanged.
Validation: 186 browser tests, 333 Controls tests (changed snapshot suite rechecked: 62), 29 Android tests and 7 Swift tests pass. TypeScript, Kotlin and Swift lint pass; local documentation link targets exist. Temporarily introducing timer overflow made the boundary test fail; restoring the implementation returned all three bridge tests to green. No image baselines were regenerated.