Skip to content

refactor: simplify capture docs and test guardrails - #60

Merged
rdlabo merged 1 commit into
mainfrom
refactor/docs-test-guardrails
Nov 16, 2026
Merged

rdlabo merged 1 commit into
mainfrom
refactor/docs-test-guardrails

Conversation

@rdlabo

@rdlabo rdlabo commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

Capture and handoff guidance repeated the same lifecycle across several pages and retained iOS-only wording despite Android contact acquisition. Consolidate that contract, link platform-specific guidance to it, and remove internal planner coefficients and a fixture-specific delay recommendation. Keep configurable defaults, platform limits and teardown requirements explicit.

Consolidate duplicate Controls cases and replace void-return assertions with observable token/ownership checks. Move long-wait and timer-overflow boundaries to the bridge layer, simplify fixtures and SDK diagnostics, and separate Window interception tests from capture-planner tests. Android restoration now checks actual window placement against the DOM within one physical pixel rather than fixing an internal translation value to 0.05px. SDK input, scroll/virtual updates and ownership guards remain covered. Product implementation is unchanged.

Validation: 186 browser tests, 333 Controls tests (changed snapshot suite rechecked: 62), 29 Android tests and 7 Swift tests pass. TypeScript, Kotlin and Swift lint pass; local documentation link targets exist. Temporarily introducing timer overflow made the boundary test fail; restoring the implementation returned all three bridge tests to green. No image baselines were regenerated.


Devin Review

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Devin Review

@rdlabo
rdlabo merged commit a4b91e6 into main Nov 16, 2026
16 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant