fix(of a UI): prevent ReferenceError during SSR in SidebarMobile#8109
Open
jay7-tech wants to merge 2 commits intowebpack:mainfrom
Open
fix(of a UI): prevent ReferenceError during SSR in SidebarMobile#8109jay7-tech wants to merge 2 commits intowebpack:mainfrom
jay7-tech wants to merge 2 commits intowebpack:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an unsafe window access issue in the mobile navigation sidebar (SidebarMobile.jsx.
Currently, the component executes a raw if (window.location !== undefined) during the render path. In Server-Side Rendering (SSR) environments (like when the docs are built on the Node.js backend), directly evaluating the window object throws a native ReferenceError.
I swapped these out for the standard isomorphic guard (typeof window !== 'undefined') to guarantee crash-free backend builds and eliminate unseen React hydration mismatches on mobile devices.
What kind of change does this PR introduce?
Thiss Bug Fix / Refactor
Did you add tests for your changes?
N/A (Just updating standard JS environment type guards).
Does this PR introduce a breaking change?
No.
If relevant, what needs to be documented once your changes are merged or what have you already documented?
N/A
Use of AI
(to write the statement for doc)