refactor(SplashViz): migrate from SCSS to Tailwind CSS#8095
refactor(SplashViz): migrate from SCSS to Tailwind CSS#8095mr-baraiya wants to merge 5 commits intowebpack:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
rahul-kr-rai
left a comment
There was a problem hiding this comment.
The current h1 heading appears to visually merge with the navbar
Please fix it.
alexander-akait
left a comment
There was a problem hiding this comment.
Please fix the above problem
|
Adjusted layout spacing by adding top padding to the section instead of margin on the heading. This ensures proper separation from the navbar. |
|
@rahul-kr-rai please take a look too |
But size of Please fix it. |
|
Updated the heading font size using exact pixel values from the original webpack.js.org design and aligned spacing with the original SCSS by using margin on the heading instead of section padding. |
Good, but the style is still different. You can open both links and see the exact difference by switching the tabs. Visit Here: ( https://webpack-js-org-git-fork-mr-baraiya-feature-splash-74c8ba-openjs.vercel.app/ and https://webpack.js.org/ ) Please fix it. |
Part of #8047
Changes
Notes