Skip to content

refactor(SplashViz): migrate from SCSS to Tailwind CSS#8095

Open
mr-baraiya wants to merge 5 commits intowebpack:mainfrom
mr-baraiya:feature/splashviz-tailwind
Open

refactor(SplashViz): migrate from SCSS to Tailwind CSS#8095
mr-baraiya wants to merge 5 commits intowebpack:mainfrom
mr-baraiya:feature/splashviz-tailwind

Conversation

@mr-baraiya
Copy link
Contributor

Part of #8047

Changes

  • Migrated SplashViz component from SCSS to Tailwind CSS
  • Removed SplashViz.scss file
  • Preserved existing UI and behavior

Notes

  • No functional changes introduced
  • Continues incremental migration away from SCSS

@vercel
Copy link

vercel bot commented Mar 22, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
webpack-js-org Ready Ready Preview, Comment Mar 23, 2026 4:24pm

Request Review

Copy link
Contributor

@rahul-kr-rai rahul-kr-rai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current h1 heading appears to visually merge with the navbar
Please fix it.

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the above problem

@mr-baraiya
Copy link
Contributor Author

Adjusted layout spacing by adding top padding to the section instead of margin on the heading. This ensures proper separation from the navbar.

@alexander-akait
Copy link
Member

@rahul-kr-rai please take a look too

@rahul-kr-rai
Copy link
Contributor

Adjusted layout spacing by adding top padding to the section instead of margin on the heading. This ensures proper separation from the navbar.

But size of h1 is diffrent form Webpack.js.org see the difference ( https://webpack-js-org-git-fork-mr-baraiya-feature-splash-74c8ba-openjs.vercel.app/ and https://webpack.js.org/)

Please fix it.

@mr-baraiya
Copy link
Contributor Author

Updated the heading font size using exact pixel values from the original webpack.js.org design and aligned spacing with the original SCSS by using margin on the heading instead of section padding.

@rahul-kr-rai
Copy link
Contributor

Adjusted layout spacing by adding top padding to the section instead of margin on the heading. This ensures proper separation from the navbar.

Good, but the style is still different. You can open both links and see the exact difference by switching the tabs.

Visit Here: ( https://webpack-js-org-git-fork-mr-baraiya-feature-splash-74c8ba-openjs.vercel.app/ and https://webpack.js.org/ )

Please fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants