feat: sponsorship & sidebar improvements#131
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
| heading="Table of Contents" | ||
| headings={{ items: headings }} | ||
| items={{ | ||
| 'Reading Time': readingTime, |
There was a problem hiding this comment.
Could we not use spreading please 🙇
Simply make a Map (or Record) and add items based on the criteria/validation, and then simply pass the record to items={{}}
There was a problem hiding this comment.
Spreading is what we use elsewhere, for instance, innodejs/learn
| }; | ||
|
|
||
| const groupsFor = path => { | ||
| if (Array.isArray(sidebar)) return sidebar; |
There was a problem hiding this comment.
We should consistently use {} or not, I recall on nodejs.org we do that, unsure if we should also keep same consistency over here.
There was a problem hiding this comment.
We don't, at the moment
ovflowd
left a comment
ovflowd
left a comment
There was a problem hiding this comment.
This PR is doing way too many things at the same time. Can at the very leas the title and PR description reflect that?
Looks a bit broken, maybe just "Featured Sponsor" |
Shouldn't the Sidebar height (border too) go through the whole page? |
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
| <SponsorTier | ||
| key={tier.tier} | ||
| tier={tier.tier} | ||
| label={tier.label} | ||
| price={tier.price[metric]} | ||
| cardSize={tier.cardSize} | ||
| sponsors={buckets[tier.tier]} | ||
| metric={metric} |
There was a problem hiding this comment.
Instead of showing the amount they're contributing, could we sort them by contribution amount from highest to lowest, or even display them randomly? I do think we shouldn't show the contribution amount in that sidebar section.
avivkeller
changed the title
It's synced on every build, and was added in #127, which is seperate |
There was a problem hiding this comment.
Please add a Become a Sponsor button
3 participants
This PR covers three related areas of navigation/UI work:
MetaBar
#theme/Metabar) showing the table of contents,reading time, authors, a fixed "Edit this page" link, and a "Featured Sponsor" card for active platinum-tier sponsors, ranked by monthly contribution.
Sidebar
about,docs) inpages/site.mjsinstead of a single global list;SideBarpicks the groupset from the first path segment. (As discussed on Discord)
site.jsonfiles (governance, loaders, plugins) usegroupNameto match the sidebar schema, and loader/plugin labels strip
-webpack-loader/-webpack-pluginsuffixes.H1 (e.g.
MEMBER_EXPECTATIONS.md) get one derived from their sidebar label.Docs
/api,/loaders,/pluginsto
/docs/api,/docs/loaders,/docs/plugins; the navbar "API" linkbecomes "Docs". Ignore files and lint configs updated to match.
cc @webpack/TSC for the sponsorship UI