Skip to content

chore: mark the query's path alias for removal in the next major release - #2485

Merged
alexander-akait merged 1 commit into
mainfrom
claude/webpack-dev-server-pr-consolidation-t0k72z
Oct 17, 2026
Merged

alexander-akait merged 1 commit into
mainfrom
claude/webpack-dev-server-pr-consolidation-t0k72z

Conversation

@alexander-akait

@alexander-akait alexander-akait commented Oct 17, 2026 •

Copy link
Copy Markdown
Member

Comment only. The client still reads path from its entry query as an alias of url, the name the query used in 8.3.0. This adds the TODO in the next major release marker next to that alias, so it is removed along with the other deprecated query names. setOptionsAndConnect({ path }) is the runtime's own API and is not affected.

No changeset: nothing user-facing changes.


Generated by Claude Code

Summary by CodeRabbit

  • Documentation
    • Documented that the query-string path option is planned for removal in the next major release; setOptionsAndConnect({ path }) remains the runtime API.

@changeset-bot

changeset-bot Bot commented Oct 17, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: db60874

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai

coderabbitai Bot commented Oct 17, 2026

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 17b7940f-2a4c-4086-ad7e-18a858922923
📥 Commits

Reviewing files that changed from the base of the PR and between f084ec9 and db60874.

📒 Files selected for processing: 1
  • client-src/index.js

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 7 remain after this review.

Walkthrough

A TODO comment documents the planned removal of query-string path support in the next major release. It states that setOptionsAndConnect({ path }) remains the runtime API. No executable behavior changes.

Priority: ⬇️ Low

Merge Risk: ⚪ Minimal · up to db608

This change documents a planned query-string alias removal without changing current behavior or the runtime API, so no PR-introduced merge risk remains.

Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely describes the comment-only change that marks the query-string path alias for removal in the next major release.
Docstring Coverage Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Oct 17, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.59%. Comparing base (f084ec9) to head (db60874).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2485   +/-   ##
=======================================
  Coverage   96.59%   96.59%           
=======================================
  Files          24       24           
  Lines        2640     2640           
=======================================
  Hits         2550     2550           
  Misses         90       90           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@alexander-akait
alexander-akait merged commit 34e1a27 into main Oct 17, 2026
24 checks passed
@alexander-akait
alexander-akait deleted the claude/webpack-dev-server-pr-consolidation-t0k72z branch October 17, 2026 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant