Skip to content

Make registerTool() return a promise#200

Merged
domfarolino merged 5 commits into
webmachinelearning:mainfrom
beaufortfrancois:promise
Jun 8, 2026
Merged

Make registerTool() return a promise#200
domfarolino merged 5 commits into
webmachinelearning:mainfrom
beaufortfrancois:promise

Conversation

@beaufortfrancois

@beaufortfrancois beaufortfrancois commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

This PR makes the registerTool() method return a Promise; fixes #175.


Preview | Diff

Comment thread index.bs Outdated
@domfarolino

Copy link
Copy Markdown
Collaborator

I pushed some small fixes up:

Can you take a look @beaufortfrancois? If it looks good to you, I think we can merge.

@domfarolino domfarolino merged commit ec37ec4 into webmachinelearning:main Jun 8, 2026
2 checks passed
github-actions Bot added a commit that referenced this pull request Jun 8, 2026
SHA: ec37ec4
Reason: push, by domfarolino

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@beaufortfrancois

Copy link
Copy Markdown
Contributor Author

@domfarolino Thanks for the fixes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Consider making registerTool() return a Promise

3 participants