Make registerTool() return a promise#200
Merged
Merged
Conversation
domfarolino
reviewed
Jun 8, 2026
Collaborator
|
I pushed some small fixes up:
Can you take a look @beaufortfrancois? If it looks good to you, I think we can merge. |
bwalderman
approved these changes
Jun 8, 2026
github-actions Bot
added a commit
that referenced
this pull request
Jun 8, 2026
SHA: ec37ec4 Reason: push, by domfarolino Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Contributor
Author
|
@domfarolino Thanks for the fixes! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes the
registerTool()method return aPromise; fixes #175.Preview | Diff