Add a failing test for X-column ordering inside a Y band - #235
Draft
webdevred wants to merge 2 commits into
Draft
Conversation
The five frontmost nodes in the y-sorting fixture sit in two vertical columns that Y and Z cannot separate, so sorting a band by Z alone interleaves them. The fixture already had the positions, so it now serves both this and the y-sorting-threshold test.
webdevred
force-pushed
the
x-column-sorting
branch
from
August 20, 2026 19:32
c6be83d to
db9744d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The five frontmost left-side vertices in the y-sorting fixture sit in two vertical columns that Y and Z cannot separate, so a band sorted by Z alone climbs one column, jumps to the other and comes back. This adds the test that pins the wanted order. It is a draft because nothing implements it yet: the test fails, and the branch deliberately carries no production change. #234 has the geometry and why no y-sorting-threshold can fix it.
The threshold in the test is not free choice, and that is the part worth a second look. At 0.31 all five vertices land in one band, which is where the defect lives. Between 0.153 and 0.16 the Y bands happen to land on exactly the two columns and the assertion passes with nothing fixed at all, so the test would claim coverage it does not have. Both of those were run, not reasoned about.
No new fixture. The positions were already in
examples/regression_jbeam/y-sorting-repro.jbeam, so that file now serves two tests and its comment says so, which is the one edit here outside test code.