chore: use swc 47 #712
Merged
chore: use swc 47 #712
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for rstest-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Copilot finished reviewing on behalf of
9aoy
November 21, 2025 04:17
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the project's build tooling dependencies to use a canary version of Rspack core that includes SWC 47 support. The main changes include upgrading @rsbuild/core from beta to stable, overriding @rspack/core with a canary build, and updating the coverage instrumentation plugin.
- Updates @rsbuild/core from 1.6.0-beta.1 to 1.6.7 across multiple packages
- Adds pnpm override to use @rspack-canary/core@1.6.5-canary-57e2a56d-20251120152633
- Updates swc-plugin-coverage-instrument from 0.0.31 to 0.0.32
Reviewed Changes
Copilot reviewed 11 out of 12 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| pnpm-lock.yaml | Updated lockfile with canary Rspack bindings, Rsbuild 1.6.7, and swc-plugin-coverage-instrument 0.0.32; includes new CSS loader configurations and JSON handling rules |
| package.json | Added pnpm override to replace @rspack/core with canary version |
| packages/core/package.json | Updated @rsbuild/core dependency from beta to 1.6.7 |
| packages/vscode/package.json | Updated @rsbuild/core dependency from beta to 1.6.7 |
| packages/coverage-istanbul/package.json | Updated swc-plugin-coverage-instrument to exact version 0.0.32 |
| examples/react/package.json | Updated @rsbuild/core dependency from beta to 1.6.7 |
| e2e/vue/fixtures/package.json | Updated @rsbuild/core dependency from beta to 1.6.7 |
| e2e/projects/fixtures/packages/client/package.json | Updated @rsbuild/core dependency from beta to 1.6.7 |
| e2e/dom/fixtures/package.json | Updated @rsbuild/core dependency from beta to 1.6.7 |
| packages/core/tests/core/snapshots/rstest.test.ts.snap | Removed undefined properties from snapshots (cleaner output) |
| packages/core/tests/core/snapshots/rsbuild.test.ts.snap | Updated snapshots to reflect new Rspack config with lightningcss-loader and JSON handling rules |
| packages/core/tests/snapshots/config.test.ts.snap | Removed undefined properties from snapshots (cleaner output) |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Since SWC 46 is incompatible with
swc-plugin-coverage-instrument, we will skip SWC 46 (rspack 1.6 and rsbuild 1.6). Instead, SWC 47 will be used in rspack 1.7, and rstest will directly use the canary version of rspack / rsbuild 1.7 with SWC 47.Related Links
fix #676
kwonoj/swc-plugin-coverage-instrument#279
web-infra-dev/rspack#12253
Checklist