Skip to content

Conversation

@Timeless0911
Copy link
Contributor

@Timeless0911 Timeless0911 commented Nov 6, 2025

Summary

Enable Rslib's advanced ESM features for @rslib/core and create-rslib.

image
  • shorthand params (not blocked)
image

Related Links

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@netlify
Copy link

netlify bot commented Nov 6, 2025

Deploy Preview for rslib ready!

Name Link
🔨 Latest commit c02ef93
🔍 Latest deploy log https://app.netlify.com/projects/rslib/deploys/6911aa53b8700d00078f06fe
😎 Deploy Preview https://deploy-preview-1325--rslib.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@Timeless0911 Timeless0911 force-pushed the enhance-esm branch 2 times, most recently from 48ae807 to e1836c3 Compare November 10, 2025 08:54
@Timeless0911 Timeless0911 marked this pull request as ready for review November 10, 2025 09:49
Copilot AI review requested due to automatic review settings November 10, 2025 09:49
@Timeless0911 Timeless0911 enabled auto-merge (squash) November 10, 2025 09:50
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR upgrades @rspack/core to a canary version and enables the advancedEsm experimental feature for ESM build outputs in the core and create-rslib packages.

  • Upgrades @rspack/core to canary version 1.6.2-canary-ae75bb5c-20251110081755 via package override
  • Enables experiments.advancedEsm in packages/core and packages/create-rslib configurations
  • Updates test snapshots to reflect new module ID hashing from the canary version

Reviewed Changes

Copilot reviewed 10 out of 11 changed files in this pull request and generated no comments.

Show a summary per file
File Description
pnpm-workspace.yaml Adds override to use @rspack/core canary version
pnpm-lock.yaml Updates lockfile with canary package references and dependency version strings
tests/integration/shims/index.test.ts Updates test snapshot with new module ID (1~368.cjs instead of 1~7.cjs)
tests/integration/resolve/index.test.ts Updates test snapshots with new module IDs (?27ce instead of ?b5d4)
tests/integration/output/index.test.ts Updates test snapshots with new chunk IDs (0~159.js and 1~159.js instead of 0~188.js and 1~188.js)
tests/integration/minify/index.test.ts Updates test snapshots with new module IDs and hash values
tests/integration/entry/index.test.ts Updates test snapshots with new chunk ID (994.js instead of 359.js)
packages/create-rslib/rslib.config.ts Enables experiments.advancedEsm for ESM format
packages/core/rslib.config.ts Enables experiments.advancedEsm for ESM format
packages/core/setupRstestTests.ts Adds snapshot serializer to normalize @rspack/core and @rspack-canary/core package names
packages/core/tests/snapshots/config.test.ts.snap Updates snapshot to use normalized <RSPACK_CORE> marker
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Timeless0911 Timeless0911 merged commit f210f60 into main Nov 10, 2025
23 checks passed
@Timeless0911 Timeless0911 deleted the enhance-esm branch November 10, 2025 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants