Skip to content

Bump phpseclib/phpseclib to 3.0.50 and fix tests #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mrts wants to merge 1 commit into
base: main
Choose a base branch
from
+57 −51
Open

Bump phpseclib/phpseclib to 3.0.50 and fix tests #51

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
61 changes: 32 additions & 29 deletions composer.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

41 changes: 22 additions & 19 deletions example/composer.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion tests/util/CollectionsUtilTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ public function testUriCollection(): void
public function testGetSubjectDns(): void
{
$x509Collection = X509Collection::getSubjectDNs(null, Certificates::getTestEsteid2018CA());
$this->assertEquals("C=EE, O=SK ID Solutions AS/2.5.4.97=NTREE-10747013, CN=TEST of ESTEID2018", $x509Collection[0]);
$this->assertEquals("C=EE, O=SK ID Solutions AS/organizationIdentifier=NTREE-10747013, CN=TEST of ESTEID2018", $x509Collection[0]);
}

public function testWhenUriIsWrongTypeThenThrows(): void
Expand Down
4 changes: 2 additions & 2 deletions tests/validator/ocsp/OcspServiceProviderTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ public function testWhenDesignatedOcspServiceConfigurationProvidedThenCreatesDes
public function testWhenAiaOcspServiceConfigurationProvidedThenCreatesAiaOcspService(): void
{
// In PHP validation is different
// we need to use TEST_of_EE-GovCA2018.pem.crt (getAiaOcspServiceConfiguration()) certificate for validation
// we need to use TEST_of_EE-GovCA2018.pem.crt (getAiaOcspServiceConfiguration()) certificate for validation

$ocspServiceProvider = OcspServiceMaker::getAiaOcspServiceProvider();

Expand All @@ -72,7 +72,7 @@ public function testWhenAiaOcspServiceConfigurationProvidedThenCreatesAiaOcspSer
$this->assertFalse($service2015->doesSupportNonce());

$this->expectException(CertificateNotTrustedException::class);
$this->expectExceptionMessage("Certificate C=EE, O=AS Sertifitseerimiskeskus/2.5.4.97=NTREE-10747013, CN=TEST of ESTEID-SK 2015 is not trusted");
$this->expectExceptionMessage("Certificate C=EE, O=AS Sertifitseerimiskeskus/organizationIdentifier=NTREE-10747013, CN=TEST of ESTEID-SK 2015 is not trusted");
$service2015->validateResponderCertificate(Certificates::getTestEsteid2015CA(), new DateTime("Thursday, August 26, 2021 5:46:40 PM"));
}

Expand Down
Loading