Conversation
* OpenSSL 3.5.6 * Qt 6.11.1 WE2-1218, WE2-1219 Signed-off-by: Raul Metsma <raul@metsma.ee>
mrts
reviewed
May 18, 2026
| <Chain> | ||
| <MsiPackage Id="WebEID" InstallCondition="VersionNT64" ForcePerMachine="yes" | ||
| SourceFile="$(var.webeid).qt.msi" Compressed="yes"> | ||
| <MsiPackage Id="WebEID.X64" InstallCondition="NOT ARCH="ARM64"" |
Member
There was a problem hiding this comment.
Isn't the install condition too broad now? This essentially allows installation on 32-bit Windows XP.
Contributor
Author
There was a problem hiding this comment.
This does not prevent successful install. It just does not install msi package then
mrts
reviewed
May 18, 2026
| #### Dual-arch installer (x64 + ARM64) | ||
|
|
||
| - Add _Qt_ binary directory to path: | ||
| Use `build.ps1` to build both architectures and produce a combined installer bundle. |
Member
There was a problem hiding this comment.
build.ps1 requires setting $VCPKG_ROOT:
[string]$vcpkgroot = $env:VCPKG_ROOT,
Contributor
Author
There was a problem hiding this comment.
or you can provide -vcpkgroot argument to powershell script.
https://learn.microsoft.com/en-us/vcpkg/users/config-environment#vcpkg_root
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WE2-1218, WE2-1219
Signed-off-by: Raul Metsma raul@metsma.ee