Repository navigation
Conversation
…e request Signed-off-by: Christopher Krah <48338417+chrikrah@users.noreply.github.com>
There was a problem hiding this comment.
Orca Security Scan Summary
| Status | Check | Issues by priority | |
|---|---|---|---|
| Infrastructure as Code | View in Orca | ||
| SAST | View in Orca | ||
| Secrets | View in Orca | ||
| Vulnerabilities | View in Orca |
|
To avoid any confusion in the future about your contribution to Weaviate, we work with a Contributor License Agreement. If you agree, you can simply add a comment to this PR that you agree with the CLA so that we can merge. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
collection.aggregate.near_image(...)raisesTypeErroron every server from 1.29 up, before it sends anything. This adds the six media fields to__create_requestand passes them on toAggregateRequest. No open issue covers it._AggregateGRPC.near_mediaspreads_parse_media(...)into__create_request. That signature has nonear_imageparameter, and none for audio, video, depth, thermal or imu.AggregateRequesthas all six fields. The integration tests for this method carry a skip since img2vec-neural left CI, so no test ran the gRPC path.Before, at
09c59d0, the new mock test calls the public API:After #2197 drops the GraphQL fallback, this path is the only one
aggregate.near_imagehas.Verification
Baseline on
09c59d0is542 passed, 1 skippedand71 passed, so the delta is the seven new tests. One mock test goes throughcollection.aggregate.near_image. The other six check the request for each media type. Revertinggrpc/aggregate.pyand keeping the tests gives7 failed, all on theTypeErrorabove.ruff checkandruff format --diff(0.14.7),flake8andpyright1.1.399 onweaviate/report clean on the branch.@g-despot since #2197 routes every aggregation through gRPC, could this one go in alongside it?