Skip to content

test: add unit tests for _get_valid_timeout_config#2092

Open
eeshsaxena wants to merge 1 commit into
weaviate:mainfrom
eeshsaxena:test/timeout-config
Open

test: add unit tests for _get_valid_timeout_config#2092
eeshsaxena wants to merge 1 commit into
weaviate:mainfrom
eeshsaxena:test/timeout-config

Conversation

@eeshsaxena

Copy link
Copy Markdown

Description

weaviate.util._get_valid_timeout_config validates the client's
timeout_config argument - accepting a single number (expanded to a
(connect, read) pair) or a 2-tuple of positive numbers, and raising on bad
input. It had no direct test coverage.

This adds test/test_timeout_config.py covering:

  • a single int / float expanding to a pair
  • a valid 2-tuple returned unchanged
  • ValueError on non-positive numbers, wrong-length tuples, and tuples
    containing a non-positive number
  • TypeError on None, strings, bools, and tuples containing non-numbers or
    bools (bools are explicitly rejected even though bool is a subclass of
    int)

No source changes.

Verification

pytest test/test_timeout_config.py - 15 passed. ruff check /
ruff format --check clean.

@orca-security-eu orca-security-eu Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Orca Security Scan Summary

Status Check Issues by priority
Passed Passed Infrastructure as Code high 0   medium 0   low 0   info 0 View in Orca
Passed Passed SAST high 0   medium 0   low 0   info 0 View in Orca
Passed Passed Secrets high 0   medium 0   low 0   info 0 View in Orca
Passed Passed Vulnerabilities high 0   medium 0   low 0   info 0 View in Orca

@weaviate-git-bot

Copy link
Copy Markdown

To avoid any confusion in the future about your contribution to Weaviate, we work with a Contributor License Agreement. If you agree, you can simply add a comment to this PR that you agree with the CLA so that we can merge.

beep boop - the Weaviate bot 👋🤖

PS:
Are you already a member of the Weaviate Forum?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants