Skip to content

test: add unit tests for BaseEnum membership support#2091

Open
eeshsaxena wants to merge 1 commit into
weaviate:mainfrom
eeshsaxena:test/str-enum
Open

test: add unit tests for BaseEnum membership support#2091
eeshsaxena wants to merge 1 commit into
weaviate:mainfrom
eeshsaxena:test/str-enum

Conversation

@eeshsaxena

Copy link
Copy Markdown

Description

weaviate/str_enum.py provides BaseEnum/MetaEnum, which add in
support to enums (e.g. "ALL" in ConsistencyLevel), but had no dedicated
test. This adds test/test_str_enum.py covering:

  • a member name string being contained
  • an unknown string not being contained
  • a member value string not counting as a membership match
  • an enum member being contained
  • a non-string (which lacks .name) not being contained

No source changes.

Verification

pytest test/test_str_enum.py - 5 passed. ruff check / ruff format --check clean.

@orca-security-eu orca-security-eu Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Orca Security Scan Summary

Status Check Issues by priority
Passed Passed Infrastructure as Code high 0   medium 0   low 0   info 0 View in Orca
Passed Passed SAST high 0   medium 0   low 0   info 0 View in Orca
Passed Passed Secrets high 0   medium 0   low 0   info 0 View in Orca
Passed Passed Vulnerabilities high 0   medium 0   low 0   info 0 View in Orca

@weaviate-git-bot

Copy link
Copy Markdown

To avoid any confusion in the future about your contribution to Weaviate, we work with a Contributor License Agreement. If you agree, you can simply add a comment to this PR that you agree with the CLA so that we can merge.

beep boop - the Weaviate bot 👋🤖

PS:
Are you already a member of the Weaviate Forum?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants