Skip to content

Add client version to GRPC headers#1980

Merged
dirkkul merged 2 commits intomainfrom
client_version_grpc
Mar 9, 2026
Merged

Add client version to GRPC headers#1980
dirkkul merged 2 commits intomainfrom
client_version_grpc

Conversation

@dirkkul
Copy link
Collaborator

@dirkkul dirkkul commented Mar 9, 2026

No description provided.

Copilot AI review requested due to automatic review settings March 9, 2026 12:09
Copy link

@orca-security-eu orca-security-eu bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Orca Security Scan Summary

Status Check Issues by priority
Passed Passed Infrastructure as Code high 0   medium 0   low 0   info 0 View in Orca
Passed Passed SAST high 0   medium 0   low 0   info 0 View in Orca
Passed Passed Secrets high 0   medium 0   low 0   info 0 View in Orca
Passed Passed Vulnerabilities high 0   medium 0   low 0   info 0 View in Orca

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds the Python client version identifier to outgoing gRPC metadata so Weaviate can observe client identity/version consistently across REST and gRPC calls.

Changes:

  • Include x-weaviate-client in gRPC metadata prepared by weaviate/connect/v4.py.
  • Add a mock gRPC servicer + fixture to capture invocation metadata in tests.
  • Add a test asserting the x-weaviate-client metadata value matches the expected client version string.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
weaviate/connect/v4.py Adds x-weaviate-client to gRPC metadata generation.
mock_tests/conftest.py Introduces a mock gRPC service + fixture to capture request metadata.
mock_tests/test_collection.py Adds an assertion that gRPC calls include the expected client version header.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.88%. Comparing base (1b1e069) to head (55e56f0).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1980      +/-   ##
==========================================
- Coverage   87.88%   87.88%   -0.01%     
==========================================
  Files         280      280              
  Lines       21463    21482      +19     
==========================================
+ Hits        18863    18879      +16     
- Misses       2600     2603       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dirkkul dirkkul merged commit 5ca709e into main Mar 9, 2026
122 of 123 checks passed
@dirkkul dirkkul deleted the client_version_grpc branch March 9, 2026 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants