Conversation
There was a problem hiding this comment.
Orca Security Scan Summary
| Status | Check | Issues by priority | |
|---|---|---|---|
| Infrastructure as Code | View in Orca | ||
| SAST | View in Orca | ||
| Secrets | View in Orca | ||
| Vulnerabilities | View in Orca |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds the Python client version identifier to outgoing gRPC metadata so Weaviate can observe client identity/version consistently across REST and gRPC calls.
Changes:
- Include
x-weaviate-clientin gRPC metadata prepared byweaviate/connect/v4.py. - Add a mock gRPC servicer + fixture to capture invocation metadata in tests.
- Add a test asserting the
x-weaviate-clientmetadata value matches the expected client version string.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
weaviate/connect/v4.py |
Adds x-weaviate-client to gRPC metadata generation. |
mock_tests/conftest.py |
Introduces a mock gRPC service + fixture to capture request metadata. |
mock_tests/test_collection.py |
Adds an assertion that gRPC calls include the expected client version header. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1980 +/- ##
==========================================
- Coverage 87.88% 87.88% -0.01%
==========================================
Files 280 280
Lines 21463 21482 +19
==========================================
+ Hits 18863 18879 +16
- Misses 2600 2603 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bevzzz
approved these changes
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.