Conversation
DanielJanicek
changed the title
![orca-security-eu[bot]](https://avatars.githubusercontent.com/in/276244?s=60&v=4){kind=small}
There was a problem hiding this comment.
Orca Security Scan Summary
| Status | Check | Issues by priority | |
|---|---|---|---|
 Passed |
Infrastructure as Code |  0  0  0  0 |
View in Orca |
| Passed |
SAST | 0 0 0 0 |
View in Orca |
| Passed |
Secrets | 0 0 0 0 |
View in Orca |
| Passed |
Vulnerabilities | 0 0 0 0 |
View in Orca |
DanielJanicek
force-pushed
the
djanicek/incremental-backups
branch
from
6fa2834 to
59a74fb
Compare
DanielJanicek
force-pushed
the
djanicek/incremental-backups
branch
from
59a74fb to
5ac900d
Compare
requirements-dev.txt
Outdated
| @@ -1,4 +1,5 @@ | |||
| weaviate-client>=4.16.7 | |||
| # weaviate-client>=4.16.7 | |||
| weaviate-client@git+https://github.com/weaviate/weaviate-python-client.git@incremental_backup_support | |||
There was a problem hiding this comment.
I would like to avoid having this PR merged pointing at a specific branch. Could we maybe make sure that the relevant weaviate-python-client PR gets merged first?
Also, unit tests have been added for the backup manager now. Could you please make sure that test coverage is added?
Last, but not least, it would be great if you could keep the Claude skill updated with the latest changes in https://github.com/weaviate/weaviate-cli/blob/main/.claude/skills/operating-weaviate-cli/references/backups.md. If loading Claude Code from the weaviate-cli directory, it will load directly both skills. You can ask it to take care of adding support in the skill.
|
Also, linting is failing in: would reformat /home/runner/work/weaviate-cli/weaviate-cli/weaviate_cli/managers/backup_manager.py , please fix. |
2 participants
This threads incremental_backup_base_id through to the new python client so that the backup manager supports incremental backup.