-
Notifications
You must be signed in to change notification settings - Fork 4
Add structured outputs to Ask Mode #95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
d83398a
feat: added parsing of structured outputs
dannyjameswilliams 97d467a
output_format can be dict, updated parse_ask_result, typing of final …
dannyjameswilliams 38269e8
overload city
dannyjameswilliams 7c4de2c
change default from str to None
dannyjameswilliams 444e22c
Merge branch 'main' into feat/structured_output
dannyjameswilliams 20be91e
refactor: move parse_ask_response to inside parse_sse
dannyjameswilliams fa5a87e
Merge branch 'feat/structured_output' of https://github.com/weaviate/…
dannyjameswilliams File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dannyjameswilliams can you help me understand this?
You say the bound of the type is a dict or any BaseModel? What does that do?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the late response. The bound lets a users own model flow through with their own fields intact, rather than just being a generic BaseModel/dict
So if the user inputs a basemodel, e.g.
then type checkers know to expect those fields in the response, so doing e.g.
will be recognised as their respective types and so on.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah got it! Thanks so much! 🧠