Skip to content

Batch Approval for AI Tool Calls, fix "AI is thinking" message, chunk JS #2430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sawka merged 6 commits into from
Oct 14, 2025
Merged

Batch Approval for AI Tool Calls, fix "AI is thinking" message, chunk JS #2430

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d02597f
working on batch approval of read-file tools...
sawka Oct 14, 2025
89d97ef
bundle monaco, shiki, mermaid, etc separately
sawka Oct 14, 2025
c9f527c
simpler batching logic
sawka Oct 14, 2025
46ee88b
fix the "streaming" / "AI is thinking..." message
sawka Oct 14, 2025
f141131
simplified thinking indicator logic, refactored common code for appro…
sawka Oct 14, 2025
a732267
fix out of order hook issue, and hack for windows paths in vite manua…
sawka Oct 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ make/
artifacts/
mikework/
.env
out

# Yarn Modern
.pnp.*
Expand Down
15 changes: 15 additions & 0 deletions electron.vite.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,21 @@ export default defineConfig({
input: {
index: "index.html",
},
output: {
manualChunks(id) {
const p = id.replace(/\\/g, "/");
if (p.includes("node_modules/monaco") || p.includes("node_modules/@monaco")) return "monaco";
if (p.includes("node_modules/mermaid") || p.includes("node_modules/@mermaid"))
return "mermaid";
if (p.includes("node_modules/katex") || p.includes("node_modules/@katex")) return "katex";
if (p.includes("node_modules/shiki") || p.includes("node_modules/@shiki")) {
return "shiki";
}
if (p.includes("node_modules/cytoscape") || p.includes("node_modules/@cytoscape"))
return "cytoscape";
return undefined;
},
},
Comment on lines +133 to +147

@coderabbitai coderabbitai Bot Oct 14, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

manualChunks path checks may miss packages and Windows paths

  • Windows backslashes can break id.includes("node_modules/...").
  • Likely scopes are different: @shikijs (not @shiki), @monaco-editor (not @monaco), @mermaid-js (not @mermaid).

Use normalized paths and correct scopes:

-                output: {
-                    manualChunks(id) {
-                        if (id.includes("node_modules/monaco") || id.includes("node_modules/@monaco")) return "monaco";
-                        if (id.includes("node_modules/mermaid") || id.includes("node_modules/@mermaid"))
-                            return "mermaid";
-                        if (id.includes("node_modules/katex") || id.includes("node_modules/@katex")) return "katex";
-                        if (id.includes("node_modules/shiki") || id.includes("node_modules/@shiki")) {
-                            return "shiki";
-                        }
-                        if (id.includes("node_modules/cytoscape") || id.includes("node_modules/@cytoscape"))
-                            return "cytoscape";
-                        return undefined;
-                    },
-                },
+                output: {
+                    manualChunks(id) {
+                        const p = id.replace(/\\/g, "/");
+                        if (p.includes("/node_modules/monaco-editor") || p.includes("/node_modules/@monaco-editor"))
+                            return "monaco";
+                        if (p.includes("/node_modules/mermaid") || p.includes("/node_modules/@mermaid-js"))
+                            return "mermaid";
+                        if (p.includes("/node_modules/katex") || p.includes("/node_modules/@katex")) return "katex";
+                        if (p.includes("/node_modules/shiki") || p.includes("/node_modules/@shikijs")) return "shiki";
+                        if (p.includes("/node_modules/cytoscape") || p.includes("/node_modules/@cytoscape"))
+                            return "cytoscape";
+                        return undefined;
+                    },
+                },
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
output: {
manualChunks(id) {
if (id.includes("node_modules/monaco") || id.includes("node_modules/@monaco")) return "monaco";
if (id.includes("node_modules/mermaid") || id.includes("node_modules/@mermaid"))
return "mermaid";
if (id.includes("node_modules/katex") || id.includes("node_modules/@katex")) return "katex";
if (id.includes("node_modules/shiki") || id.includes("node_modules/@shiki")) {
return "shiki";
}
if (id.includes("node_modules/cytoscape") || id.includes("node_modules/@cytoscape"))
return "cytoscape";
return undefined;
},
},
output: {
manualChunks(id) {
// normalize Windows backslashes to forward slashes
const p = id.replace(/\\/g, "/");
if (p.includes("/node_modules/monaco-editor") || p.includes("/node_modules/@monaco-editor"))
return "monaco";
if (p.includes("/node_modules/mermaid") || p.includes("/node_modules/@mermaid-js"))
return "mermaid";
if (p.includes("/node_modules/katex") || p.includes("/node_modules/@katex"))
return "katex";
if (p.includes("/node_modules/shiki") || p.includes("/node_modules/@shikijs"))
return "shiki";
if (p.includes("/node_modules/cytoscape") || p.includes("/node_modules/@cytoscape"))
return "cytoscape";
return undefined;
},
},

Comment on lines +133 to +147

@coderabbitai coderabbitai Bot Oct 14, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

Chunk matchers miss Monaco and scoped packages; normalize paths

  • Monaco is published as monaco-editor, not monaco; current checks won’t match.
  • On Windows, ids may contain backslashes.
  • Mermaid is commonly @mermaid-js/; Shiki often under @shikijs/.

Refine matching and normalize separators.

Apply this diff to harden matching:

-                output: {
-                    manualChunks(id) {
-                        if (id.includes("node_modules/monaco") || id.includes("node_modules/@monaco")) return "monaco";
-                        if (id.includes("node_modules/mermaid") || id.includes("node_modules/@mermaid"))
-                            return "mermaid";
-                        if (id.includes("node_modules/katex") || id.includes("node_modules/@katex")) return "katex";
-                        if (id.includes("node_modules/shiki") || id.includes("node_modules/@shiki")) {
-                            return "shiki";
-                        }
-                        if (id.includes("node_modules/cytoscape") || id.includes("node_modules/@cytoscape"))
-                            return "cytoscape";
-                        return undefined;
-                    },
-                },
+                output: {
+                    manualChunks(id) {
+                        const p = id.replace(/\\/g, "/");
+                        if (p.includes("/node_modules/monaco-editor")) return "monaco";
+                        if (p.includes("/node_modules/mermaid") || p.includes("/node_modules/@mermaid-js/"))
+                            return "mermaid";
+                        if (p.includes("/node_modules/katex") || p.includes("/node_modules/@katex/")) return "katex";
+                        if (p.includes("/node_modules/shiki") || p.includes("/node_modules/@shikijs/")) return "shiki";
+                        if (p.includes("/node_modules/cytoscape") || p.includes("/node_modules/@cytoscape/"))
+                            return "cytoscape";
+                        return undefined;
+                    },
+                },
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
output: {
manualChunks(id) {
if (id.includes("node_modules/monaco") || id.includes("node_modules/@monaco")) return "monaco";
if (id.includes("node_modules/mermaid") || id.includes("node_modules/@mermaid"))
return "mermaid";
if (id.includes("node_modules/katex") || id.includes("node_modules/@katex")) return "katex";
if (id.includes("node_modules/shiki") || id.includes("node_modules/@shiki")) {
return "shiki";
}
if (id.includes("node_modules/cytoscape") || id.includes("node_modules/@cytoscape"))
return "cytoscape";
return undefined;
},
},
output: {
manualChunks(id) {
const p = id.replace(/\\/g, "/");
if (p.includes("/node_modules/monaco-editor")) return "monaco";
if (p.includes("/node_modules/mermaid") || p.includes("/node_modules/@mermaid-js/"))
return "mermaid";
if (p.includes("/node_modules/katex") || p.includes("/node_modules/@katex/")) return "katex";
if (p.includes("/node_modules/shiki") || p.includes("/node_modules/@shikijs/")) return "shiki";
if (p.includes("/node_modules/cytoscape") || p.includes("/node_modules/@cytoscape/"))
return "cytoscape";
return undefined;
},
},
🤖 Prompt for AI Agents 
In electron.vite.config.ts around lines 133 to 146, the manualChunks path checks
miss actual package names and Windows backslashes; normalize id by replacing
backslashes with forward slashes, and match real package names and common scoped
names: check for "monaco-editor" and both "@monaco" and "@monaco-editor" scopes,
"@mermaid-js" (and "mermaid"), "@katex" or "katex", "@shikijs" (and "shiki"),
and "@cytoscape" (and "cytoscape"); return the appropriate chunk names when
those normalized paths include the target strings. Ensure you normalize id once
at the top of manualChunks and use strict includes against the normalized path.

},
},
optimizeDeps: {
Expand Down
Loading
Loading