Respect Markdown Viewer preference for file URLs

[fadexadex]

Description

Respects the Markdown Viewer preference for incoming file:// Markdown URLs.

Previously, the URI handler classified every Markdown file as a notebook before reading editor settings. If macOS handed a Markdown file back to Warp through a file:// URL, Warp opened the internal Markdown Viewer even when Open Markdown files in Warp's Markdown Viewer by default was disabled. This now routes Markdown files through the editor path when that preference is disabled.

Linked Issue

Fixes #8878

• The linked issue is labeled ready-to-spec or ready-to-implement.
• Where appropriate, screenshots or a short video of the implementation are included below (especially for user-visible or UI changes).

Testing

• Added regression coverage for disabled Markdown Viewer routing in uri_tests.rs.
• ./script/format
• cargo test -p warp test_open_file_markdown_routes_to_editor_when_viewer_disabled passed after locally applying the equivalent of upstream PRs warpui_core: fix StoredView missing child_view_ids (clippy CI failure) #12845/warpui_core: fix wasm compilation by adding StoredView::child_view_ids #12848 to unblock the current origin/master warpui_core compile error. That unrelated unblocker is not included in this PR.
• I have manually tested my changes locally with ./script/run

Screenshots / Videos

before.and.after.mp4

Changelog Entries for Stable

CHANGELOG-BUG-FIX: Fixed Markdown files opening in Warp's Markdown Viewer from macOS file URLs even when the Markdown Viewer preference is disabled.

[oz-for-oss]

@fadexadex

I'm starting a first review of this pull request.

You can view the conversation on Warp.

I completed the review and no human review was requested for this pull request.

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

[oz-for-oss]

Overview

This PR updates file:// Markdown routing so the Markdown Viewer preference is checked before choosing the notebook viewer path, with regression coverage for both enabled and disabled preference states.

Concerns

• For this user-facing change, please include screenshots or a short screen recording demonstrating the file URL open behavior end to end with the Markdown Viewer preference disabled. This change is visible to users because it changes whether a Markdown file opens in the Markdown Viewer or editor, and the repository review guidance requires visual evidence for user-facing behavior changes.

Verdict

Found: 0 critical, 1 important, 0 suggestions

Request changes

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

[oz-for-oss]

@fadexadex

I'm starting a first review of this pull request.

You can view the conversation on Warp.

I completed the review and no human review was requested for this pull request.

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

[oz-for-oss]

Overview

This PR updates file:// Markdown routing so the Markdown Viewer preference controls whether Markdown files open in the notebook viewer or the editor path, and it adds regression coverage for both preference states.

Concerns

• ⚠️ [IMPORTANT] This user-facing file-open behavior lacks screenshots or a screen recording demonstrating it working end to end. Unit coverage is useful, but repo guidance requires visual evidence for user-visible behavior; please attach a short local or computer-use recording.

Verdict

Found: 0 critical, 1 important, 0 suggestions

Request changes

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

[fadexadex]

/oz-review I have added one to the pr description.

[oz-for-oss]

@fadexadex

I'm re-reviewing this pull request in response to a review request.

You can view the conversation on Warp.

I reviewed this pull request and requested human review from: @bnavetta.

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

Oz no longer requests changes for this pull request after the latest automated review.

[oz-for-oss]

Overview

This PR updates file:// Markdown routing so Warp only opens Markdown files in the Markdown Viewer when code.editor.prefer_markdown_viewer is enabled, and otherwise sends them through the editor path. It also updates the URI routing tests to cover both preference states.

Concerns

• No blocking correctness, security, or spec-alignment concerns found. The attached spec context contains no approved or repository spec to enforce, and the PR description includes visual evidence for the user-facing behavior.

Verdict

Found: 0 critical, 0 important, 0 suggestions

Approve

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz