Skip to content

Fix warpui_core StoredView compile error and tui test file naming#12850

Draft
warp-dev-github-integration[bot] wants to merge 1 commit into
zb/tui-backend/03b-tui-elementsfrom
oz/fix-tui-stored-view-child-view-ids
Draft

Fix warpui_core StoredView compile error and tui test file naming#12850
warp-dev-github-integration[bot] wants to merge 1 commit into
zb/tui-backend/03b-tui-elementsfrom
oz/fix-tui-stored-view-child-view-ids

Conversation

@warp-dev-github-integration

Copy link
Copy Markdown
Contributor

Description

Fixes the two CI failures on PR #12634 (zb/tui-backend/03b-tui-elements).

1. Run Linux testswarpui_core failed to compile

AppContext::collect_transferable_subtree calls view.child_view_ids(self) on a &StoredView (crates/warpui_core/src/core/app.rs:3306), but the StoredView enum never had a child_view_ids forwarding method, producing:

error[E0599]: no method named `child_view_ids` found for reference `&core::window::StoredView` in the current scope

This adds StoredView::child_view_ids, delegating to the GUI view (AnyView::child_view_ids) and returning an empty vec for TUI views, matching the existing neutral-hook delegation pattern in window.rs.

Note: the failing call is in app.rs and is not gated behind the tui feature, so this breaks the default build as well. The same omission exists on master (the child_view_ids call and the StoredView enum are identical there), so this also fixes a latent breakage on master caused by a semantic merge.

2. Miscellaneous checks — incorrectly named test file

CI flags any *_test.rs file (must be *_tests.rs). Renamed elements/tui/mod_test.rsmod_tests.rs and wired it into elements/tui/mod.rs with the standard include, matching sibling test files:

#[cfg(test)]
#[path = "mod_tests.rs"]
mod tests;

Validation

  • cargo check -p warpui_core (default features) — compiles
  • cargo check -p warpui_core --features tui — compiles
  • cargo test -p warpui_core --lib --no-run (default features, as CI builds) — compiles
  • cargo fmt --check -p warpui_core — clean
  • cargo clippy -p warpui_core --all-targets --tests -- -D warnings — clean
  • test-file naming check and script/check_no_inline_test_modules — pass

Conversation: https://staging.warp.dev/conversation/62baaa87-02be-47dc-8ded-5130a8019d66
Run: https://oz.staging.warp.dev/runs/019ee255-0043-755f-922d-17629603cf1d

This PR was generated with Oz.

Two CI failures on this branch:

1. `Run Linux tests` failed to compile `warpui_core`: `collect_transferable_subtree`
   calls `view.child_view_ids(self)` on a `&StoredView`, but `StoredView` had no
   such forwarding method. Add `StoredView::child_view_ids`, delegating to the GUI
   view and returning an empty vec for TUI views (matching the existing neutral-hook
   pattern). This affects the default build (not just the `tui` feature), so it also
   resolves the same breakage present on master.

2. `Miscellaneous checks` failed the test-file naming lint: `mod_test.rs` must be
   `mod_tests.rs`. Rename it and wire it into `tui/mod.rs` via the standard
   `#[cfg(test)] #[path = "mod_tests.rs"] mod tests;` include, matching sibling
   test files.

Co-Authored-By: Oz <oz-agent@warp.dev>
@cla-bot cla-bot Bot added the cla-signed label Jun 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant