Fix warpui_core StoredView compile error and tui test file naming#12850
Draft
warp-dev-github-integration[bot] wants to merge 1 commit into
Draft
Conversation
Two CI failures on this branch: 1. `Run Linux tests` failed to compile `warpui_core`: `collect_transferable_subtree` calls `view.child_view_ids(self)` on a `&StoredView`, but `StoredView` had no such forwarding method. Add `StoredView::child_view_ids`, delegating to the GUI view and returning an empty vec for TUI views (matching the existing neutral-hook pattern). This affects the default build (not just the `tui` feature), so it also resolves the same breakage present on master. 2. `Miscellaneous checks` failed the test-file naming lint: `mod_test.rs` must be `mod_tests.rs`. Rename it and wire it into `tui/mod.rs` via the standard `#[cfg(test)] #[path = "mod_tests.rs"] mod tests;` include, matching sibling test files. Co-Authored-By: Oz <oz-agent@warp.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes the two CI failures on PR #12634 (
zb/tui-backend/03b-tui-elements).1.
Run Linux tests—warpui_corefailed to compileAppContext::collect_transferable_subtreecallsview.child_view_ids(self)on a&StoredView(crates/warpui_core/src/core/app.rs:3306), but theStoredViewenum never had achild_view_idsforwarding method, producing:This adds
StoredView::child_view_ids, delegating to the GUI view (AnyView::child_view_ids) and returning an empty vec for TUI views, matching the existing neutral-hook delegation pattern inwindow.rs.Note: the failing call is in
app.rsand is not gated behind thetuifeature, so this breaks the default build as well. The same omission exists onmaster(thechild_view_idscall and theStoredViewenum are identical there), so this also fixes a latent breakage onmastercaused by a semantic merge.2.
Miscellaneous checks— incorrectly named test fileCI flags any
*_test.rsfile (must be*_tests.rs). Renamedelements/tui/mod_test.rs→mod_tests.rsand wired it intoelements/tui/mod.rswith the standard include, matching sibling test files:Validation
cargo check -p warpui_core(default features) — compilescargo check -p warpui_core --features tui— compilescargo test -p warpui_core --lib --no-run(default features, as CI builds) — compilescargo fmt --check -p warpui_core— cleancargo clippy -p warpui_core --all-targets --tests -- -D warnings— cleanscript/check_no_inline_test_modules— passConversation: https://staging.warp.dev/conversation/62baaa87-02be-47dc-8ded-5130a8019d66
Run: https://oz.staging.warp.dev/runs/019ee255-0043-755f-922d-17629603cf1d
This PR was generated with Oz.