warpui_core: fix wasm compilation by adding StoredView::child_view_ids#12848
Draft
warp-dev-github-integration[bot] wants to merge 1 commit into
Draft
warpui_core: fix wasm compilation by adding StoredView::child_view_ids#12848warp-dev-github-integration[bot] wants to merge 1 commit into
warp-dev-github-integration[bot] wants to merge 1 commit into
Conversation
Fixes the wasm release-flags compilation failure where `collect_transferable_subtree` called `view.child_view_ids(self)` on a `&StoredView`. The neutral-hook subset on `StoredView` delegates most `View`/`AnyView` hooks, but `child_view_ids` was missing, so the method could not resolve (E0599). Add an inherent `child_view_ids` that delegates to the GUI view and returns an empty set for TUI views, matching the existing delegation pattern for the other neutral hooks. Co-Authored-By: Oz <oz-agent@warp.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes the Verify compilation with release flags (wasm) CI failure on PR #12634 (branch
zb/tui-backend/03b-tui-elements).The wasm release build failed with:
StoredViewis the type-erased view enum (Gui+ cfg-gatedTui) stored in each window's registry. Its inherent impl delegates the "neutral hook" subset ofView/AnyViewmethods (ui_name,on_focus,on_blur,keymap_context, etc.), butchild_view_idswas never added.collect_transferable_subtreecallsview.child_view_ids(self)on a&StoredView, which could not resolve because the method is only available on theAnyView/Viewtraits, whichStoredViewdoes not implement.This adds an inherent
child_view_idsmethod toStoredViewthat delegates to the GUI view and returns an empty set for TUI views, matching the existing delegation pattern used for the other neutral hooks (and consistent with how TUI views are treated as non-participants in the other GUI-centric flows).Testing
./script/wasm/bundle --channel oss --nouniversal --check-only— now finishes successfully (previously failed with E0599).cargo fmt --check -p warpui_corepasses.cargo clippy -p warpui_coreandcargo clippy -p warpui_core --features tuiboth pass with no warnings (verifying both match arms).Agent Mode
Conversation: https://staging.warp.dev/conversation/0b76d629-ff67-4bd0-b063-765da26bae60
Run: https://oz.staging.warp.dev/runs/019ee255-1b18-7e40-8891-66da978aa9a8
This PR was generated with Oz.