Fix TUI elements build/test compile errors (CI fix for #12634)#12846
Draft
warp-dev-github-integration[bot] wants to merge 1 commit into
Draft
Fix TUI elements build/test compile errors (CI fix for #12634)#12846warp-dev-github-integration[bot] wants to merge 1 commit into
warp-dev-github-integration[bot] wants to merge 1 commit into
Conversation
Add the missing `child_view_ids` delegation to `StoredView` so `collect_transferable_subtree` compiles, fix missing geometry/buffer imports in `tui_view_tests`, and add a test-only no-op `TuiElement` impl for `()` used as a leaf placeholder in the TUI element tests. Co-Authored-By: Oz <oz-agent@warp.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes the failing Formatting + Clippy (Linux) check on #12634 (
zb/tui-backend/03b-tui-elements). The TUI elements slice did not compile under--all-targets --all-features --tests:collect_transferable_subtreeincrates/warpui_core/src/core/app.rscallsview.child_view_ids(self)on a&StoredView, but theStoredViewenum (introduced alongside the additive TUI registry) never gained achild_view_idsdelegation. Added it, delegating to the GUI view and returning an emptyVecfor thetuivariant (matching the other GUI-only hook delegations likeself_or_child_interacted_with).tui_view_tests.rsdefinesTuiEmpty: TuiElementbut only importedTuiElement, not theTuiConstraint/TuiSize/TuiRect/TuiBuffertypes it references. Added the missing imports.child_view_tests.rs,container_tests.rs, andevent_handler_tests.rsuseBox::new(())as a trivial no-op leaf element, but()did not implementTuiElement. Added a#[cfg(test)]no-opimpl TuiElement for ()next to the trait definition.This PR targets the
zb/tui-backend/03b-tui-elementsbranch so it can be merged into the original PR.Validation
cargo clippy -p warpui_core --all-targets --all-features --tests -- -D warningspassescargo fmt -- --checkcleancargo nextest run -p warpui_core --features tui— 335 passed, 7 skippedConversation: https://staging.warp.dev/conversation/77c61f4b-58dc-4c6b-91c8-cb48f0c04d21
Run: https://oz.staging.warp.dev/runs/019ee253-bd9c-7e7f-acf7-14021692c87e
This PR was generated with Oz.