Fix wasm/master build: add child_view_ids to StoredView#12844
Draft
warp-dev-github-integration[bot] wants to merge 1 commit into
Draft
Fix wasm/master build: add child_view_ids to StoredView#12844warp-dev-github-integration[bot] wants to merge 1 commit into
warp-dev-github-integration[bot] wants to merge 1 commit into
Conversation
PR #12633 converted `Window::views` from `Box<dyn AnyView>` to the new `StoredView` enum and added inherent delegating methods for the neutral view hooks, but missed `child_view_ids`. The view-subtree transfer logic in `AppContext::collect_transferable_subtree` still calls `view.child_view_ids(self)` on a `&StoredView`, so master fails to compile with E0599 (no method named `child_view_ids`), breaking the "Formatting + Clippy (wasm)" CI job (and all other targets). Add a `child_view_ids` delegating method to `StoredView` following the same pattern as the other neutral hooks: forward to the inner `AnyView` for the `Gui` variant and return an empty vec for the `Tui` variant (which has no child-ownership graph), matching how the other read-only ownership hooks treat TUI views. CHANGELOG-NONE Co-Authored-By: Oz <oz-agent@warp.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes a compile break on
masterthat is failing the CI / Formatting + Clippy (wasm) job (and all other targets) at commit1ef980b.PR #12633 ("Add TUI API surface to AppContext under
tui") convertedWindow::viewsfromHashMap<EntityId, Box<dyn AnyView>>to the newStoredViewenum and added inherent delegating methods for the neutral view hooks (as_any,ui_name,on_focus,on_blur,keymap_context,active_cursor_position,on_window_closed,on_window_transferred,self_or_child_interacted_with,accessibility_data) — but missedchild_view_ids.The view-subtree transfer logic in
AppContext::collect_transferable_subtree(crates/warpui_core/src/core/app.rs:3306) still callsview.child_view_ids(self)on a&StoredView, so the build fails with:This is a merge-skew regression: the
child_view_ids-based transfer walk and theStoredViewrefactor landed in separate PRs that each passed CI against the oldmaster, but break when combined.Fix
Add a
child_view_idsdelegating method toStoredViewfollowing the established pattern of the other neutral hooks: forward to the innerAnyViewfor theGuivariant, and return an empty vec for theTuivariant (consistent with how the other read-only ownership hooks treat TUI views).Testing
cargo check --locked -p warpui_core— compiles cleanly (previously failed with E0599).cargo clippy --locked -p warpui_core --all-targets --tests -- -D warnings— passes.cargo fmt -p warpui_core -- --check— passes.Agent Mode
CHANGELOG-NONE
Conversation: https://staging.warp.dev/conversation/2e780cd2-38f5-436f-9ee9-57d959968777
Run: https://oz.staging.warp.dev/runs/019ee252-a720-7c96-bc86-446bc56a7a34
This PR was generated with Oz.