Clarify warpctrl admin install fallback#12838
Conversation
Co-Authored-By: Oz <oz-agent@warp.dev>
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
There was a problem hiding this comment.
Overview
This PR clarifies the bundled Warp Control skill's /usr/local/bin install fallback by replacing the vague elevated-permissions instruction with an explicit osascript command that quotes both path arguments and relies on the standard macOS administrator dialog.
Concerns
- No blocking correctness, security, or spec-alignment concerns found in the attached diff.
Verdict
Found: 0 critical, 0 important, 0 suggestions
Approve
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
Description
Updates the bundled Warp Control skill's installation fallback to invoke an explicit, argument-safe
osascriptcommand when/usr/local/binrequires elevated permissions. This produces the standard macOS administrator dialog, avoids asking agents to usesudoor handle passwords, and treats cancellation as declining installation while continuing with the bundled wrapper.Linked Issue
No linked issue.
ready-to-specorready-to-implement.Testing
Compiled the AppleScript fallback with
osacompilewithout executing it.Ran
git diff --check.Ran
./script/format.Ran
cargo clippy --workspace --all-targets --all-features --tests -- -D warnings.I have manually tested my changes locally with
./script/runScreenshots / Videos
Not applicable; this changes bundled skill instructions.
Agent Mode
CHANGELOG-NONE
Co-Authored-By: Oz oz-agent@warp.dev