Skip to content

fix focus stealing#12833

Open
harryalbert wants to merge 2 commits into
masterfrom
harry/app-4763-queued-prompt-editor-closes-when-new-tool-calls-stream-in
Open

fix focus stealing#12833
harryalbert wants to merge 2 commits into
masterfrom
harry/app-4763-queued-prompt-editor-closes-when-new-tool-calls-stream-in

Conversation

@harryalbert

@harryalbert harryalbert commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

Description

There was an issue where, whenever the agent executed a tool call, the queued prompt editor would close. This was because the editor closes on-blur, but there's some refocus events that happen in the course of a normal conversation that we need to explicitly ignore (the regular input already does this).

Testing

  • I have manually tested my changes locally with ./script/run

Screenshots / Videos

https://www.loom.com/share/f43ace3fd18e4239a24f114d53443761

Agent Mode

  • Warp Agent Mode - This PR was created via Warp's AI Agent Mode

@cla-bot cla-bot Bot added the cla-signed label Jun 19, 2026

Copy link
Copy Markdown
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@harryalbert harryalbert requested a review from advait-m June 19, 2026 14:50
@harryalbert harryalbert marked this pull request as ready for review June 19, 2026 14:50
@oz-for-oss

oz-for-oss Bot commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

@harryalbert

I'm starting a first review of this pull request.

You can view the conversation on Warp.

I completed the review and no human review was requested for this pull request.

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

@oz-for-oss oz-for-oss Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overview

This PR prevents asynchronous AI/tool focus reconciliation from stealing focus away from the queued-prompt inline editor, and adds a focused regression test for terminal focus redetermination while a queued prompt is being edited.

Concerns

No blocking correctness, security, or spec-drift concerns found. The PR includes visual evidence for the user-facing behavior change.

Verdict

Found: 0 critical, 0 important, 0 suggestions

Approve

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

@harryalbert harryalbert force-pushed the harry/app-4763-queued-prompt-editor-closes-when-new-tool-calls-stream-in branch from 0075b29 to ff8a260 Compare June 19, 2026 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant