feat: gate git credential refresh behind GitCredentialRefresh flag (dogfood only)#10397
Merged
jasonkeung merged 1 commit intomasterfrom May 7, 2026
Merged
Conversation
Adds a `GitCredentialRefresh` feature flag to control the driver behavior introduced in #10153 (credential file writes and background refresh loop). The flag is enabled for dogfood builds only, so the feature can be validated internally before wider rollout. - `FeatureFlag::GitCredentialRefresh` added to the enum and wired through the compile-time bridge in `app/src/lib.rs` - `DOGFOOD_FLAGS` includes the new flag - `mod.rs`: the `git_credentials` fetch future short-circuits to `Ok(vec![])` and the write block is skipped when the flag is off - `driver.rs`: `task_id_for_refresh` is set to `None` (suppressing the refresh loop) when the flag is off Co-Authored-By: Oz <oz-agent@warp.dev>
Contributor
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
![oz-for-oss[bot]](https://avatars.githubusercontent.com/in/3450139?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Overview
This PR adds a dogfood-only GitCredentialRefresh feature flag and gates the Git credential fetch/write path plus the background refresh loop behind it.
Concerns
- Manual testing evidence is missing for this behavioral change. Please include screenshots, a screen recording, or equivalent command/log output showing dogfood builds still fetch/write/refresh credentials and stable/preview builds skip those paths, or justify why manual testing is not possible.
Verdict
Found: 0 critical, 1 important, 0 suggestions
Request changes
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
abhishekp106
approved these changes
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GitCredentialRefreshfeature flag to gate the credential-writing and background refresh-loop behavior introduced in [REMOTE-1370] Phase 2b: driver credential writes and refresh loop #10153DOGFOOD_FLAGS); off by default in Preview and Stable buildsgit_credentialsfetch future short-circuits toOk(vec![]), the credential file write block is skipped, andtask_id_for_refreshis forced toNoneso the background refresh loop never spawnsFiles changed
crates/warp_features/src/lib.rsGitCredentialRefreshvariant; added toDOGFOOD_FLAGSapp/Cargo.tomlgit_credential_refresh = []Cargo featureapp/src/lib.rs#[cfg(feature = "git_credential_refresh")] FeatureFlag::GitCredentialRefreshapp/src/ai/agent_sdk/mod.rsapp/src/ai/agent_sdk/driver.rstask_id_for_refresh) behind flagTest plan
loop still working with flag enabled: https://www.loom.com/share/14d64e5c90414328a9a9387d9820be7c
git_credential_refreshfeature) —git_credentialsreturns early, no credential files written, no refresh loop spawnedThis PR was created by Oz (running Claude Code).