Draft
Conversation
Add warn-level logging around project rule discovery, pending context assembly, API serialization, and conversation restoration so missing active_rule_files can be diagnosed without logging rule contents. Co-Authored-By: Oz <oz-agent@warp.dev>
Add targeted warnings for metadata, non-directory, file tree, file-limit, and per-file read failures during project rule scans. Continue scanning after an unreadable rule file so one bad file does not suppress later active_rule_files. Co-Authored-By: Oz <oz-agent@warp.dev>
Member
Author
|
I will likely revert this one I've found the issue |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds warn-level diagnostics around project rule context propagation to help debug inconsistent
active_rule_filespopulation.Specifically, this logs when:
active_rule_filesactive_rule_filesThe scan now continues after a single unreadable rule file instead of aborting the rest of the candidate rule files. The logs include paths and counts, but not rule file contents.
Oz conversation: https://staging.warp.dev/conversation/ef46e7dd-4e1f-4c9f-aa80-a743789d309e
Linked Issue
N/A
ready-to-specorready-to-implement.Screenshots / Videos
N/A — logging-only change.
Testing
cargo fmtcargo check -p warp --lib --features local_fscargo clippy --workspace --all-targets --all-features --tests -- -D warningscargo fmtandcargo clippy --workspace --all-targets --all-features --tests -- -D warningsafter mergingorigin/master.cargo fmt,cargo check -p warp --lib --features local_fs, andcargo clippy --workspace --all-targets --all-features --tests -- -D warnings.No new tests were added because this is diagnostic logging only and does not change project-rule behavior, aside from continuing a scan after a single unreadable candidate rule file.
Agent Mode
Co-Authored-By: Oz oz-agent@warp.dev