Skip to content

Fix tmux statusline color leaking into alt screen#10132

Open
MeteorSkyOne wants to merge 1 commit intowarpdotdev:masterfrom
MeteorSkyOne:meteorskyone/fix-tmux-alt-screen-bg
Open

Fix tmux statusline color leaking into alt screen#10132
MeteorSkyOne wants to merge 1 commit intowarpdotdev:masterfrom
MeteorSkyOne:meteorskyone/fix-tmux-alt-screen-bg

Conversation

@MeteorSkyOne
Copy link
Copy Markdown

@MeteorSkyOne MeteorSkyOne commented May 5, 2026

Description

Fixes a tmux rendering issue where transient status line background colors could leak into the alternate screen and Warp footer background inference while shell initialization is still settling.

The change does two things:

  • Clears a fresh DECSET 1049 alternate screen with the terminal default background instead of the current cursor template background.
  • Samples empty ligature-rendered rows as transparent/default background so tmux statusline colors do not become the inferred alternate-screen background.

Linked Issue

No matching upstream issue found for this focused bug fix.

Screenshots / Videos

Do The agent tooltip bar becomes green when ligature is enabled.

Testing

  • cargo fmt -p warp
  • cargo test -p warp test_enter_alt_screen_clears_with_default_background
  • cargo test -p warp tmux_
  • cargo test -p warp alt_reset
  • cargo clippy -p warp --all-targets --tests -- -D warnings
  • cargo clippy --locked --workspace --exclude warp_completer --all-targets --tests -- -D warnings
  • cargo clippy --locked -p warp_completer --all-targets --tests -- -D warnings

Also attempted cargo clippy --workspace --all-targets --all-features --tests -- -D warnings, but in this local external setup it enables release_bundle without an installed private warp-channel-config binary, so the warp build script does not generate local/dev/preview/stable_config.json and the app bins fail at include_str!. The current script/presubmit and CI lint workflow use the --workspace --exclude warp_completer --all-targets --tests clippy command above instead, with a repo TODO to re-enable --all-features later.

Agent Mode

  • Warp Agent Mode - This PR was created via Warp's AI Agent Mode

Changelog Entries for Stable

CHANGELOG-BUG-FIX: Fixed tmux status line colors leaking into alternate screen background rendering.

Co-Authored-By: Warp agent@warp.dev

Prevent transient tmux status line colors from seeding the alternate screen grid or Warp footer background inference.

Co-Authored-By: Warp <agent@warp.dev>
@cla-bot
Copy link
Copy Markdown

cla-bot Bot commented May 5, 2026

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @MeteorSkyOne on file. In order for us to review and merge your code, each contributor must visit https://cla.warp.dev to read and agree to our CLA. Once you have done so, please comment @cla-bot check to trigger another check.

@oz-for-oss
Copy link
Copy Markdown
Contributor

oz-for-oss Bot commented May 5, 2026

@MeteorSkyOne

I'm starting a first review of this pull request.

You can view the conversation on Warp.

I reviewed this pull request and requested human review from: @warpdotdev/oss-maintainers.

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

@github-actions github-actions Bot added the external-contributor Indicates that a PR has been opened by someone outside the Warp team. label May 5, 2026
@MeteorSkyOne
Copy link
Copy Markdown
Author

@cla-bot check

@cla-bot cla-bot Bot added the cla-signed label May 5, 2026
@cla-bot
Copy link
Copy Markdown

cla-bot Bot commented May 5, 2026

The cla-bot has been summoned, and re-checked this pull request!

Copy link
Copy Markdown
Contributor

@oz-for-oss oz-for-oss Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overview

This PR adjusts alternate-screen clearing and ligature-rendered empty-row background sampling so transient tmux status-line backgrounds do not seed the alternate-screen/footer background inference.

Concerns

  • No blocking correctness, security, or performance concerns identified in the changed lines.

Verdict

Found: 0 critical, 0 important, 0 suggestions

Approve

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

@oz-for-oss oz-for-oss Bot requested review from a team and alokedesai and removed request for a team May 5, 2026 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed external-contributor Indicates that a PR has been opened by someone outside the Warp team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant