Open
Conversation
- Differentiate task cancellation from genuine failures in executeTask; cancelled tasks no longer send a TaskFailed message to the server - Use background context for container cleanup (remove) so it succeeds even when the task context is already cancelled - Explicitly stop the running container when the task context is cancelled during ContainerWait, using a background context with timeout Co-Authored-By: Oz <oz-agent@warp.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Handle task cancellation
Adds support for receiving
task_cancellationmessages from the server via WebSocket and gracefully cancelling running tasks.Changes
Message types (
internal/types/messages.go):MessageTypeTaskCancellationandTaskCancellationMessagestructWorker (
internal/worker/worker.go):task_cancellationmessages in the WebSocket message handlerhandleTaskCancellation: looks up the task's cancel function and invokes itexecuteTask: distinguishes cancellation from genuine failures — cancelled tasks no longer send aTaskFailedmessage to the serverexecuteTaskInDocker: uses a background context (with timeout) for container cleanup so removal succeeds even when the task context is already cancelledexecuteTaskInDocker: explicitly stops the running container when the task context is cancelled duringContainerWaitThis PR was generated with Oz.