Add opt-in Helm support for the command backend - #123
Conversation
Expose backend.type=command while keeping kubernetes (task Jobs) as the default chart path, and document how to mount dispatch scripts in-cluster. Co-Authored-By: Warp Agent <agent@warp.dev>
There was a problem hiding this comment.
Overview
This adds an opt-in command backend to the Helm chart while preserving the existing Kubernetes default. The rendered template behavior is correct in the exercised cases, but the new path needs durable coverage and the documented install flow needs revision before merge.
Concerns
- The Helm job still lints and renders only default values, so none of the new
backend.type=commandbranches are protected. Add committed Helm tests or CI assertions for command config/args/volumes, Role/RoleBinding presence by mode, invalid backend rejection, and the required dispatch command. - The chart overview still says the chart always deploys Role/RoleBinding and always creates one Kubernetes Job per task. Qualify those statements by backend: task RBAC and Jobs exist only for
kubernetes;commandinvokes the mounted dispatcher.
Verdict
Checks: build pass, tests pass, CI green, visual proof n/a
Found: 0 critical, 4 important, 1 suggestion, 0 nits
Co-Authored-By: Warp Agent <agent@warp.dev>
All review findings were addressed in 6b1658f, the three inline threads are resolved, and all seven required checks pass.
There was a problem hiding this comment.
Overview
The revision addresses all prior findings: command-mode Helm coverage is committed, the setup flow is namespace-correct, the Python image requirement is explicit, Secret wiring is safe, and the backend-specific chart behavior is documented. Approve.
Verdict
Checks: build pass, tests pass, CI green, visual proof n/a
Found: 0 critical, 0 important, 0 suggestions, 0 nits
Summary
backend.type=commandpath to the Helm chart so the worker can run in Kubernetes and dispatch via a mounted script instead of creating task Jobs.backend.type=kubernetes).Test plan
helm lintwith default values and command-backend valuesbackend.command, mounts, and omits task Job/Pod Role/RoleBindingCo-Authored-By: Warp Agent agent@warp.dev