Open
Conversation
added 2 commits
June 4, 2021 16:27
Contributor
Author
|
Hi @waldo1001, I see this PR is still pending. Anyway I have added the BC19 url for current updates. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Microsoft has changed a couple of things with CU page and also the url for the download links. For some reason link to the downloads is now "regionalized" to en-gb rather than en-us. Therefore I had to update the GetDownloadLocales function in the MicrosoftDownloadParser class. I checked with people in Sweden and the US to make sure it is the same for them (as I am in GB) and it is. The function will check for either en-us or en-gb now.
It may not be the most elegant C# code but I am not sure if all the new features in C# are supported in PowerShell versions so I tried to keep it simple.