Sharing methods #3
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JSON.parse(resp.to_s).
Make required parameters just plain old params, and all optional parameters named params with a default.
spatten
force-pushed
the
sharing
branch
2 times, most recently
from
af7e9d4 to
766313f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the following methods to Client:
list_shared_folderscontinue_list_shared_foldersshare_folderadd_folder_membermount_folderlist_folder_membersrelinquish_folder_membershiptransfer_folderThere are tests for everything, and an integration test that goes through the following workflow:
This requires a second Dropbox access token passed in as
DROPBOX_SDK_ACCESS_TOKEN_2.I think that's it. This is a pretty big change, but I tried my best to maintain the same style as in the existing code. Hopefully it's all good.
Thanks,
Scott