Add extended parameter list folder #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lib/dropbox/client.rb
Outdated
| recursive = false, | ||
| include_media_info = false, | ||
| include_deleted = false, | ||
| include_has_explicit_shared_members = false ) |
There was a problem hiding this comment.
how about
def list_folder(path, recursive: false, include_media_info: false, include_deleted: false, include_has_explicit_shared_members: false)
end?
This way we can explicitly pass the parameters as key-value pairs.
There was a problem hiding this comment.
+1 as this feels more ruby-esque
and bump as I'm in need of the recursive option right now. =P
There was a problem hiding this comment.
@epylinkn before this PR is merged, you can use this fork for now
https://github.com/gogovan/dropbox-sdk-ruby/tree/list-folder-method-allows-params
|
@waits Any chance of merging this soon? Thanks! |
|
@PascalSenn nice thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds extended parameters for fields for