Update the algorithm to ensure that the config is set as part of a successful configure#943
Merged
Merged
Conversation
…ccessful configure. In the video ouptut algorithm, mention that partial config color space can be augmented with codec implementation detected color space. As a fly-by fix, we also make sure that the encoders get their active config set to the config given to configure.
Contributor
Author
|
Partially fixes #940. |
dalecurtis
reviewed
Jul 7, 2026
| 5. If {{VideoDecoderConfig/colorSpace}} [=map/exists=] in the | ||
| {{VideoDecoder/[[active decoder config]]}}, assign its value to | ||
| |colorSpace|. | ||
| |colorSpace|. In that case, if some members of |
Contributor
Author
There was a problem hiding this comment.
I updated the wording, hopefully it is better now.
dalecurtis
approved these changes
Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the video output algorithm section, we now mention that partial config color space can be augmented with codec implementation detected color space. As a fly-by fix, we also make sure that the encoders get their active config set to the config given to configure.
Preview | Diff