Skip to content

feat: Configure collaborative points allocation and retain award snapshots (#64) - #66

Merged
efraespada merged 5 commits into
developfrom
feature/64-configure-collaborative-points-allocation-and-retain-award-snapshots
Nov 9, 2026
Merged

efraespada merged 5 commits into
developfrom
feature/64-configure-collaborative-points-allocation-and-retain-award-snapshots

Conversation

@efraespada

@efraespada efraespada commented Nov 9, 2026 •

Copy link
Copy Markdown
Member

Closes #64.

Summary

  • Add revisioned household defaults and task overrides for conserved, equal, full, and manual point allocation.
  • Record the effective policy, participants, exact shares, total, and remainder position with the completion. Approval and the Points worker reuse this evidence. Reopening posts one linked reversal for the awarded amounts.
  • Add the protected allocation editor and exact completion preview. Family shows retained allocation evidence on recent pending work and posted movements in English and Spanish.
  • Migrate existing schema 17 databases to schema 18 and preserve older Points receipts. Reject malformed allocation evidence during checkpoint inspection.
  • Read the completion affordance with the authorized task detail. A points administrator must review manual shares before submitting. Other members see an actionable handoff when a task requires manual shares.

Verification

  • Commit 212296c5c718e7075d527e241490f91638e97a7e passes 5,121 backend tests with 100% line and branch coverage globally and per file. The suite includes both composed HTTP paths, schema 17 migration, concurrent replay, transaction rollback, restart, and activated restoration.
  • The same commit passes 1,615 frontend tests with 100% line, branch, function, and statement coverage globally and per file, all 109 compiled Chromium journeys in Ingress and standalone, and the packaged UI asset check.
  • The Bugbot aggregate records two fixed findings and zero open findings for this commit. Copilot Verification passed.
  • The exact-head CI run supplies amd64 and ARM64 image evidence.

See the allocation behavior and test evidence for the case mapping.

@docs-page

docs-page Bot commented Nov 9, 2026

Copy link
Copy Markdown

To preview the documentation for this pull request, visit the following URL:

docs.page/vypdev/domus~66

Documentation is deployed and generated using docs.page

@vypbot vypbot added the state:ai-processing A Copilot agent is analyzing or working on the issue or change. label Nov 9, 2026
@vypbot vypbot changed the title Configure collaborative points allocation and retain award snapshots feat: Configure collaborative points allocation and retain award snapshots (#64) Nov 9, 2026
@vypbot
vypbot self-requested a review November 9, 2026 22:57
@vypbot vypbot added the size: XXL Label to indicate a task of size XXL label Nov 9, 2026
@vypbot vypbot added this to vypdev Nov 9, 2026
@vypbot vypbot moved this to In Progress in vypdev Nov 9, 2026
@vypbot
vypbot changed the base branch from develop to master November 9, 2026 22:58
@efraespada efraespada linked an issue Nov 9, 2026 that may be closed by this pull request
1 task done
@vypbot
vypbot changed the base branch from master to develop November 9, 2026 22:58
@vypbot vypbot added the 65% Progress: 65% label Nov 9, 2026

@vypbot vypbot left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Current status: All findings originating in this review are resolved.
Last reconciled on 212296c. See aggregate Bugbot status.

🤖 Bugbot review snapshot

Bugbot reported 2 potential problems when commit d1f74c9 was analyzed. This snapshot is historical; use the status block above for current state. 2 findings are linked to changed code.

Findings

  • medium: Manual allocation leaves non-managers with an unsubmitable completion form — frontend/src/application/allocation-controller.ts:67
  • low: Completion remains enabled before the effective allocation policy loads — frontend/src/presentation/domus-tasks.ts:306

@vypbot

vypbot commented Nov 9, 2026 •

Copy link
Copy Markdown

Bugbot: review complete

Current status: No active findings on 212296c.

Pull request · Verified commit · Workflow run

@vypbot vypbot added state:changes-requested Review identified changes that are required. state:awaiting-issue-author The next action requires more information or changes from the issue author. and removed state:ai-processing A Copilot agent is analyzing or working on the issue or change. labels Nov 9, 2026
@vypbot vypbot added state:ai-processing A Copilot agent is analyzing or working on the issue or change. state:ready The change is ready for human approval or merge. state:awaiting-maintainer The next action requires a maintainer response or approval. and removed state:changes-requested Review identified changes that are required. state:awaiting-issue-author The next action requires more information or changes from the issue author. state:ai-processing A Copilot agent is analyzing or working on the issue or change. labels Nov 9, 2026
@efraespada
efraespada merged commit 2e660f3 into develop Nov 9, 2026
18 checks passed
@github-project-automation github-project-automation Bot moved this from In Progress to Done in vypdev Nov 9, 2026
@vypbot vypbot added state:verified The change has passed Copilot verification. and removed state:ready The change is ready for human approval or merge. state:awaiting-maintainer The next action requires a maintainer response or approval. labels Nov 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

65% Progress: 65% size: XXL Label to indicate a task of size XXL state:verified The change has passed Copilot verification.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

✨🧑‍💻 - Configure collaborative points allocation and retain award snapshots

2 participants