Skip to content

Repository navigation

feat: Verify recurrence replacement and preserved work against durable Inventory effects (#57) - #61

Merged
efraespada merged 7 commits into
developfrom
feature/57-verify-recurrence-replacement-and-preserved-work-against-durable-inventory-effects
Nov 9, 2026
Merged

feat: Verify recurrence replacement and preserved work against durable Inventory effects (#57)#61
efraespada merged 7 commits into
developfrom
feature/57-verify-recurrence-replacement-and-preserved-work-against-durable-inventory-effects

Conversation

@efraespada

@efraespada efraespada commented Nov 9, 2026 •
edited by vypbot
Loading

Copy link
Copy Markdown
Member

Closes #57. Part of #23.

Changes

  • Persist exact task-linked reservations, demand and immutable stock movements in SQLite schema 17, using the preserved genuine schema 16 fixture for migration.
  • Bind reviewed replacements to their current Inventory effects. Transfer compatible open effects atomically to the exact linked replacement, keep manual demand and physical stock unchanged, and recover the original batch without reapplying its effects.
  • Connect task material posting in both production compositions. Preserve remaining reservations and prior movements, append linked corrections only through the explicit authorized settlement, and leave shortages pending.
  • Verify the three outstanding combined recurrence cases with actual Points awards, stock movements, reservations, demand, independent SQLite writers, rollback, restart and restoration. Keep the historical qualification and its case identifiers separate from this evidence.

Verification

The 42 focused Inventory and batch tests passed with complete statement and branch coverage in the new Inventory modules. Ruff, mypy, the application dependency contracts, 51 architecture tests, the native specification catalog validator and the documentation checker passed. The complete backend suite and the GitHub gates verify the exact change separately.

@docs-page

docs-page Bot commented Nov 9, 2026

Copy link
Copy Markdown

To preview the documentation for this pull request, visit the following URL:

docs.page/vypdev/domus~61

Documentation is deployed and generated using docs.page

@vypbot vypbot added the state:ai-processing A Copilot agent is analyzing or working on the issue or change. label Nov 9, 2026
@vypbot vypbot changed the title Verify recurrence against durable Inventory effects feat: Verify recurrence replacement and preserved work against durable Inventory effects (#57) Nov 9, 2026
@vypbot
vypbot self-requested a review November 9, 2026 18:05
@vypbot vypbot added the size: XXL Label to indicate a task of size XXL label Nov 9, 2026
@vypbot vypbot added this to vypdev Nov 9, 2026
@vypbot vypbot moved this to In Progress in vypdev Nov 9, 2026
@vypbot
vypbot changed the base branch from develop to master November 9, 2026 18:05
@efraespada efraespada linked an issue Nov 9, 2026 that may be closed by this pull request
✨🧑‍💻 - Verify recurrence replacement and preserved work against durable Inventory effects #57
Closed
1 task done
@vypbot
vypbot changed the base branch from master to develop November 9, 2026 18:05
@vypbot

vypbot commented Nov 9, 2026 •
edited
Loading

Copy link
Copy Markdown

Bugbot: review complete

Current status: No active findings on 7045b30.

Pull request · Verified commit · Workflow run

@vypbot vypbot added state:ready The change is ready for human approval or merge. state:awaiting-maintainer The next action requires a maintainer response or approval. and removed state:ai-processing A Copilot agent is analyzing or working on the issue or change. labels Nov 9, 2026
@efraespada

efraespada commented Nov 9, 2026

Copy link
Copy Markdown
Member Author

/copilot review

@vypbot vypbot added the state:ai-processing A Copilot agent is analyzing or working on the issue or change. label Nov 9, 2026
@efraespada efraespada mentioned this pull request Nov 9, 2026
Open
1 task done
@vypbot vypbot added state:ai-processing A Copilot agent is analyzing or working on the issue or change. and removed state:ai-processing A Copilot agent is analyzing or working on the issue or change. labels Nov 9, 2026
@vypbot vypbot added state:reviewing A pull request is being reviewed. and removed state:ready The change is ready for human approval or merge. state:awaiting-maintainer The next action requires a maintainer response or approval. state:ai-processing A Copilot agent is analyzing or working on the issue or change. labels Nov 9, 2026
@vypbot vypbot added the state:ai-processing A Copilot agent is analyzing or working on the issue or change. label Nov 9, 2026
vypbot
vypbot reviewed Nov 9, 2026
View reviewed changes

@vypbot vypbot left a comment •
edited
Loading

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Current status: All findings originating in this review are resolved.
Last reconciled on 7045b30. See aggregate Bugbot status.

🤖 Bugbot review snapshot

Bugbot reported 1 potential problem when commit ba53441 was analyzed. This snapshot is historical; use the status block above for current state. 1 finding is linked to changed code.

Findings

  • low: Empty occurrence list bypasses the effects check — tests/backend/test_inventory_recurrence.py:538

Comment thread tests/backend/test_inventory_recurrence.py Resolved
@vypbot vypbot added state:changes-requested Review identified changes that are required. state:awaiting-issue-author The next action requires more information or changes from the issue author. and removed state:reviewing A pull request is being reviewed. state:ai-processing A Copilot agent is analyzing or working on the issue or change. labels Nov 9, 2026
@vypbot vypbot added state:ai-processing A Copilot agent is analyzing or working on the issue or change. state:ready The change is ready for human approval or merge. state:awaiting-maintainer The next action requires a maintainer response or approval. and removed state:changes-requested Review identified changes that are required. state:awaiting-issue-author The next action requires more information or changes from the issue author. state:ai-processing A Copilot agent is analyzing or working on the issue or change. labels Nov 9, 2026
This was referenced Nov 9, 2026
Open
Closed
@efraespada
efraespada merged commit a9c0290 into develop Nov 9, 2026
18 of 21 checks passed
@github-project-automation github-project-automation Bot moved this from In Progress to Done in vypdev Nov 9, 2026
This was referenced Nov 9, 2026
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vypbot vypbot vypbot left review comments

Assignees

@efraespada efraespada

Labels

size: XXL Label to indicate a task of size XXL state:awaiting-maintainer The next action requires a maintainer response or approval. state:ready The change is ready for human approval or merge.

Projects

vypdev
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

✨🧑‍💻 - Verify recurrence replacement and preserved work against durable Inventory effects

2 participants

@efraespada @vypbot