Skip to content

Let authorized creators set base points when creating tasks - #116

Merged
efraespada merged 10 commits into
developfrom
feature/111-set-base-points-when-creating-a-task
Nov 12, 2026
Merged

efraespada merged 10 commits into
developfrom
feature/111-set-base-points-when-creating-a-task

Conversation

@efraespada

@efraespada efraespada commented Nov 12, 2026 •

Copy link
Copy Markdown
Member

Closes #111.

Creators with task configuration authority can set an optional base-point amount when creating a task. The title-only path uses the household default. Explicit amounts are stored in exact minor units and bound to the original creation receipt. Manual, fixed and relative creation apply current allocation precision before saving. A rejected fraction remains in the form and the focused field explains the correction in English and Spanish. The existing allocation rules apply to the accepted amount.

The form uses the published @vypdev/ha-ui@0.1.0-next.2 decimal keyboard hint. The current frontend passed 1,706 tests with full coverage of all 81 runtime files. The precision change passed 214 targeted backend tests, type checks, and the application architecture rules. The installed wheel and ARM64 image serve the exact reviewed frontend files.

Home Assistant Supervisor installed Edge.26 pinned to 691496c299ff371763e445acb9d36b9623a81404. In a disposable ARM64 Ingress household with a saved whole-point conserved policy, Enter on 2.25 returned the English guidance and retained the focused draft. At 390 px in Spanish, touch submission of 2,25 kept the draft and placed the visible guidance next to the focused field. The correction to 2 cleared the error, saved 2,00, completed successfully, and posted 2,00 in Family. The temporary app, its private data, and its repository source were removed. The original 14 apps and eight sources remained.

Published specification · Exact candidate CI · Independent review

@docs-page

docs-page Bot commented Nov 12, 2026

Copy link
Copy Markdown

To preview the documentation for this pull request, visit the following URL:

docs.page/vypdev/domus~116

Documentation is deployed and generated using docs.page

@efraespada
efraespada marked this pull request as ready for review November 12, 2026 12:53
@vypbot vypbot added the state:ai-processing A Copilot agent is analyzing or working on the issue or change. label Nov 12, 2026
@vypbot vypbot added state:reviewing A pull request is being reviewed. size: XXL Label to indicate a task of size XXL state:ai-processing A Copilot agent is analyzing or working on the issue or change. and removed state:ai-processing A Copilot agent is analyzing or working on the issue or change. labels Nov 12, 2026
@efraespada

efraespada commented Nov 12, 2026 •

Copy link
Copy Markdown
Member Author

Copilot Commit's progress check on b7a1324e401df1b75b675b00bdb58c4245e699fb hit the known unselected-seed defect. Issue #111 retains an optional seed. The Action's published SDD receipt records a generated publication without a selected seed or artifact. The Commit action looks up a seed publication whenever the seed markers are present and requires a selection. This stops issue progress assessment before it evaluates the implementation.

I verified that the Action's published commit c8730e0671d7c3d5e1334d1f3a700773caccd3b2 is an ancestor of the candidate. specs/household-tasks.md has identical blob e2bb3d346d829276f6000a07a9c3d8b938f414a3 at both revisions. The specification catalog passes validation and the six published cases have executable evidence in docs/evidence/task-base-points-qualification.md. This is a false positive in the progress check. The candidate still requires the full CI and the independent PR code review.

@vypbot vypbot left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Current status: All findings originating in this review are resolved.
Last reconciled on b7a1324. See aggregate Bugbot status.

🤖 Bugbot review snapshot

Bugbot reported 1 potential problem when commit 8f3c777 was analyzed. This snapshot is historical; use the status block above for current state. 1 finding is linked to changed code.

Findings

  • medium: Fractional task points can block completion under whole-point allocation — frontend/src/application/task-controller.ts:185

@vypbot

vypbot commented Nov 12, 2026 •

Copy link
Copy Markdown

Bugbot: review complete

Current status: No active findings on b7a1324.

Pull request · Verified commit · Workflow run

@vypbot vypbot added state:changes-requested Review identified changes that are required. state:awaiting-issue-author The next action requires more information or changes from the issue author. and removed state:reviewing A pull request is being reviewed. state:ai-processing A Copilot agent is analyzing or working on the issue or change. labels Nov 12, 2026
@vypbot vypbot added the state:ai-processing A Copilot agent is analyzing or working on the issue or change. label Nov 12, 2026
@vypbot vypbot added state:ready The change is ready for human approval or merge. state:awaiting-maintainer The next action requires a maintainer response or approval. and removed state:changes-requested Review identified changes that are required. state:awaiting-issue-author The next action requires more information or changes from the issue author. state:ai-processing A Copilot agent is analyzing or working on the issue or change. labels Nov 12, 2026
@vypbot vypbot added state:ai-processing A Copilot agent is analyzing or working on the issue or change. and removed state:ai-processing A Copilot agent is analyzing or working on the issue or change. labels Nov 12, 2026
@efraespada

Copy link
Copy Markdown
Member Author

Temporary Branch Sync exception for this candidate while GitHub Support handles the stranded workflow run. That run still reports queued with no allocated jobs. The candidate Branch Sync is affected by that queue.

The Action's issue command synchronized the managed feature branch with verified develop (ff6b64fec87bab3d156a0c64952387c7a33ceff1). This base is an ancestor of b7a1324e401df1b75b675b00bdb58c4245e699fb. The merge tree matches the candidate tree 6f16bff1e635013eb9bdc78bbf740c54e967a591. The full candidate CI and independent review remain the implementation gates. Normal Branch Sync verification resumes once GitHub clears the stranded run.

@efraespada
efraespada merged commit 3ea1ac0 into develop Nov 12, 2026
13 of 16 checks passed
@vypbot vypbot added state:verified The change has passed Copilot verification. and removed state:ready The change is ready for human approval or merge. state:awaiting-maintainer The next action requires a maintainer response or approval. labels Nov 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size: XXL Label to indicate a task of size XXL state:verified The change has passed Copilot verification.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants