Repository navigation
Show current-week Family participation on Overview - #110
efraespada merged 13 commits into
Conversation
|
To preview the documentation for this pull request, visit the following URL:
|
|
CI Check passed at The commit and pull request wrappers exited early for the Branch Sync PAT actor. Actual verification and review remain pending after the earlier selected-SDD verification failure linked in this PR. |
Bugbot: review complete
|
|
At Verification repeated |
|
The candidate Branch Sync is waiting in the queue affected by the stranded workflow run, which remains queued with zero jobs. The temporary exception documented for Domus applies while GitHub Support clears that run. The stalled develop Branch Sync was cancelled to release its runner after confirming that develop CI had passed. The native synchronization receipt confirms that the managed branch includes the verified The Commit progress check on |
There was a problem hiding this comment.
Current status: All findings originating in this review are resolved.
Last reconciled on74ba1a5. See aggregate Bugbot status.
🤖 Bugbot review snapshot
Bugbot reported 1 potential problem when commit 26dc3dd was analyzed. This snapshot is historical; use the status block above for current state. 1 finding is linked to changed code.
Findings
- low: Weekly summary can remain on the previous week after rollover —
frontend/src/composition/entry-page.ts:462
There was a problem hiding this comment.
Current status: All findings originating in this review are resolved.
Last reconciled on74ba1a5. See aggregate Bugbot status.
🤖 Bugbot review snapshot
Bugbot reported 1 potential problem when commit 58a2361 was analyzed. This snapshot is historical; use the status block above for current state. 1 finding is linked to changed code.
Findings
- low: Six Overview cases are covered by one test —
tests/backend/test_family_overview.py:50
Overview shows the signed-in member’s completed tasks and posted earned points for the current Family week. The server derives the week in the household’s time zone and applies the same read permissions as Family. The card offers a retry when its read fails and links to Family for the full report, including points pending verification or posting.
Edge.27 pins runtime
979319d1a874f21f2dbe525a3108034ecd0ff0d4. In a disposable Home Assistant Ingress household, Overview started at zero and showed one completed task and 2.25 points after the award posted. The same summary displayed2,25in Spanish at 390 px. Both the English keyboard link and the Spanish touch link focused Family. Reopening the task produced a linked−2,25reversal. Overview retained the historical completion count and returned to0,00earned points. The disposable app, its private data, and its repository source were removed.All six specification cases ran independently in Ingress and standalone, plus the separate scope-revocation test in both modes. All 14 tests passed. The synchronized frontend passed 1,716 tests with full coverage of 82 files. The independently built wheel matched the current UI fingerprints and passed the packaging checks.
Edge.28 adds a refresh when the household week changes while Overview is open. A mounted-page regression crosses Monday midnight in Europe/Madrid and checks that the summary rereads exactly once while the session stays open. The corrected Edge.28 package also ran in a fresh Supervisor household using Europe/Madrid. It showed the empty summary, then one completed task and the posted award in English and Spanish. The temporary app, data, and source were removed after the check.
Closes #105
Published specification · Candidate CI · Code review