Skip to content

Complete local setup assistant acceptance evidence - #403

Open
efraespada wants to merge 2 commits into
developfrom
codex/setup-web-cli-acceptance
Open

efraespada wants to merge 2 commits into
developfrom
codex/setup-web-cli-acceptance

Conversation

@efraespada

@efraespada efraespada commented Sep 29, 2026 •

Copy link
Copy Markdown
Member

This change adds a structured acceptance process for the local web setup assistant and reorganizes CLI setup execution around a coordinated setup session. The acceptance ledger and safe fixture review flow make automated coverage and outstanding human verification explicit.

What changed

  • Added a 350-case acceptance ledger and documentation for reviewing setup states, locales, accessibility, and packaged launch behavior.
  • Added a local web review fixture server with canned setup states for browser review without GitHub access or repository mutation.
  • Refactored CLI setup into focused execution, credential collection, authorization, intent, and outcome components coordinated through a setup session.
  • Added CI workflow coverage and package validation for setup acceptance and platform smoke checks.
  • Updated setup documentation and generated build artifacts to reflect the new flow.

Review notes

  • The acceptance documentation says 40 human review rows remain open; visual, language, assistive-technology, and operating-system results require direct observation and should not be inferred from automated checks.
  • Account switching, 2FA, wrong-account handling, and PAT deletion require separate authorized human review with test accounts.

@docs-page

docs-page Bot commented Sep 29, 2026

Copy link
Copy Markdown

To preview the documentation for this pull request, visit the following URL:

docs.page/vypdev/copilot~403

Documentation is deployed and generated using docs.page

@vypbot vypbot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Current status: All findings originating in this review are resolved.
Last reconciled on f56a60d. See aggregate Bugbot status.

🤖 Bugbot review snapshot

Bugbot reported 1 potential problem when commit ad7c5f4 was analyzed. This snapshot is historical; use the status block above for current state. 1 finding is linked to changed code.

Findings

  • medium: Normalize Jest paths before matching ledger evidence — scripts/validate-setup-assistant-acceptance.cjs:8

Comment thread scripts/validate-setup-assistant-acceptance.cjs
@vypbot

vypbot commented Sep 29, 2026 •

Copy link
Copy Markdown
Contributor

Bugbot: review complete

Current status: No active findings on f56a60d.

Pull request · Verified commit · Workflow run

@codecov-commenter

codecov-commenter commented Sep 29, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 93.95466% with 24 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.66%. Comparing base (274db40) to head (f56a60d).
⚠️ Report is 917 commits behind head on develop.

Files with missing lines Patch % Lines
src/cli/commands/setup_execution.ts 94.52% 2 Missing and 10 partials ⚠️
src/cli/setup_pat_intent_adapter.ts 86.48% 0 Missing and 5 partials ⚠️
...cation/usecases/setup/setup_session_coordinator.ts 93.33% 0 Missing and 3 partials ⚠️
src/cli/setup_apply_authorization.ts 94.73% 0 Missing and 1 partial ⚠️
src/cli/setup_credential_collection.ts 96.42% 0 Missing and 1 partial ⚠️
src/cli/setup_outcome_adapter.ts 96.15% 0 Missing and 1 partial ⚠️
src/cli/web_setup_bridge.ts 85.71% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #403      +/-   ##
===========================================
+ Coverage    90.94%   92.66%   +1.71%     
===========================================
  Files          135      780     +645     
  Lines         6251    22767   +16516     
  Branches      1338     6395    +5057     
===========================================
+ Hits          5685    21097   +15412     
- Misses         172      603     +431     
- Partials       394     1067     +673     
Files with missing lines Coverage Δ
src/actions/common_action.ts 94.87% <100.00%> (-3.68%) ⬇️
src/actions/local_action.ts 92.30% <100.00%> (+7.84%) ⬆️
...ication/usecases/actions/initial_setup_use_case.ts 100.00% <100.00%> (ø)
...ication/usecases/actions/initial_setup_workflow.ts 99.31% <100.00%> (ø)
src/cli/commands/setup.ts 100.00% <100.00%> (ø)
src/cli/setup_result_receipt.ts 93.93% <100.00%> (ø)
...ture/composition/initial_setup_composition_root.ts 100.00% <100.00%> (ø)
...ure/composition/main_run_route_composition_root.ts 93.22% <100.00%> (ø)
web/src/i18n/en.ts 100.00% <ø> (ø)
web/src/i18n/es.ts 100.00% <ø> (ø)
... and 9 more

... and 828 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: In Progress

Development

Successfully merging this pull request may close these issues.

3 participants