Skip to content

Add Option Never show inline code copy button and refactor the inline code copy style setting #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
catnaut wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add Option Never show inline code copy button and refactor the inline code copy style setting #18

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cf95b7b
feat: add option to show copy code icon for inline code
catnaut Dec 23, 2023
fa10588
refactor: use choice to set inline code copy style
catnaut Dec 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 20 additions & 7 deletions src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,12 +17,17 @@ const settings = [
default: "0em"
},
{
key: "AlwaysShowInlineCopyButton",
title: "Always show inline copy code button?",
description: "Check the box if you would like the copy code button to always show next to inline code. If unchecked, the copy code button will only appear when hovering over the inline code.",
default: false,
type: "boolean",
enumPicker: "checkbox"
key: "InlineCopyButtonStyle",
title: "Inline copy code button style",
description: "Choose how you would like the copy code button to appear next to inline code.",
type: "enum",
default: "Show on hover",
enumChoices: [
"Always show",
"Show on hover",
"Never show"
],
enumPicker: "select"
}
]
logseq.useSettingsSchema(settings);
Expand Down Expand Up @@ -177,13 +182,21 @@ const main = async () => {
`)

// always show the copy button for inline code
if (logseq.settings.AlwaysShowInlineCopyButton) {
if (logseq.settings.InlineCopyButtonStyle == "Always show") {
logseq.provideStyle(`
#${inline_code.id}-button {
display: inline-flex;
}
`)
}
// don't show copy button for inline code when UI inserted before setting changed
else if (logseq.settings.InlineCopyButtonStyle == "Never show") {
logseq.provideStyle(`
#${inline_code.id}-button {
display: none;
}
`)
}
// show copy button for inline code on hover
else {
logseq.provideStyle(`
Expand Down