fix: handle nested backticks in markdown code block rendering - #370
Open
sridhar-3009 wants to merge 1 commit into
Open
fix: handle nested backticks in markdown code block rendering#370sridhar-3009 wants to merge 1 commit into
sridhar-3009 wants to merge 1 commit into
Conversation
…rol#361) Add preprocessMarkdownFences() that scans markdown line-by-line before passing it to ReactMarkdown. When a fenced code block body contains a backtick run long enough to prematurely close the outer fence, the outer fence is extended by one backtick beyond the longest such inner run. This conforms to the CommonMark spec and prevents the renderer from splitting a single code block into two when the content includes triple (or longer) backtick sequences on their own line.
|
A useful edge-case test would include nested Markdown where the inner backtick run appears inside an indented list or blockquote, since fence recognition can depend on the container prefix. It may also be worth testing a body containing several backtick runs of different lengths and confirming the preprocessor chooses exactly one longer outer fence. Finally, code spans outside fenced blocks should remain byte-for-byte unchanged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a
preprocessMarkdownFences()step in theMarkdowncomponent that auto-extends the outer fence when a code block body contains a backtick run long enough to prematurely close it, preventing the renderer from splitting a single block into two.Closes #361